Skip to content

Conversation

@condo-bot
Copy link
Member

@condo-bot condo-bot commented Oct 30, 2025

Summary

  • clarify schemaDoc descriptions in user confirmation and access-related schemas
  • improve notification and ticket schema documentation for API clarity
  • update banking, onboarding, and subscription schemaDoc strings for readability

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_69027ad0f424832e81f2e98fba66eb25

Summary by CodeRabbit

Documentation

  • Improved and clarified descriptive documentation across banking, notification, onboarding, ticket, and user management schemas for better clarity and consistency.
  • Updated field descriptions to use plain language and remove redundant phrasing.

Bug Fixes

  • Added validation logic for user sudo token remaining uses to prevent invalid states.
  • Enhanced user external identity validation to ensure type consistency with linked user records.
  • Made messageType field optional in message batch schema to support flexible configurations.

Improvements

  • Enhanced message notifications with expanded access controls and improved content handling.
  • Added metadata enhancements to bank transaction fields for better integration support.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 322d471 and b8c9911.

📒 Files selected for processing (29)
  • apps/condo/domains/banking/schema/BankAccountReportTask.js (3 hunks)
  • apps/condo/domains/banking/schema/BankIntegration.js (1 hunks)
  • apps/condo/domains/banking/schema/BankIntegrationAccessRight.js (1 hunks)
  • apps/condo/domains/banking/schema/BankTransaction.js (4 hunks)
  • apps/condo/domains/notification/schema/Message.js (7 hunks)
  • apps/condo/domains/notification/schema/MessageBatch.js (3 hunks)
  • apps/condo/domains/notification/schema/MessageUserBlackList.js (1 hunks)
  • apps/condo/domains/notification/schema/NotificationAnonymousSetting.js (3 hunks)
  • apps/condo/domains/notification/schema/TelegramUserChat.js (1 hunks)
  • apps/condo/domains/notification/schema/_internalSendNotificationNewMobileAppVersionService.js (1 hunks)
  • apps/condo/domains/onboarding/schema/SyncTourStepsService.js (1 hunks)
  • apps/condo/domains/onboarding/schema/TourStep.js (1 hunks)
  • apps/condo/domains/onboarding/schema/UserHelpRequest.js (3 hunks)
  • apps/condo/domains/onboarding/schema/UserHelpRequestFile.js (1 hunks)
  • apps/condo/domains/subscription/schema/ServiceSubscription.js (1 hunks)
  • apps/condo/domains/ticket/schema/IncidentChange.js (2 hunks)
  • apps/condo/domains/ticket/schema/TicketComment.js (4 hunks)
  • apps/condo/domains/ticket/schema/TicketDocumentGenerationTask.js (9 hunks)
  • apps/condo/domains/ticket/schema/TicketFile.js (1 hunks)
  • apps/condo/domains/ticket/schema/TicketOrganizationSetting.js (4 hunks)
  • apps/condo/domains/ticket/schema/TicketPlaceClassifier.js (1 hunks)
  • apps/condo/domains/ticket/schema/TicketSource.js (2 hunks)
  • apps/condo/domains/ticket/schema/UserTicketCommentReadTime.js (3 hunks)
  • apps/condo/domains/user/schema/ConfirmEmailAction.js (3 hunks)
  • apps/condo/domains/user/schema/ConfirmPhoneAction.js (1 hunks)
  • apps/condo/domains/user/schema/OidcClient.js (3 hunks)
  • apps/condo/domains/user/schema/ResetUserLimitAction.js (3 hunks)
  • apps/condo/domains/user/schema/UserExternalIdentity.js (2 hunks)
  • apps/condo/domains/user/schema/UserSudoToken.js (2 hunks)
 ___________________________________________________
< Great artists ship, but not before a code review. >
 ---------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/review-and-update-schemadoc-texts-hwdxim

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link


finishAt: {
schemaDoc: 'When subscription should be ended',
schemaDoc: 'Subscription end date and time.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are so much docs, which can be assessed and understood in two ways


unitPrice: {
schemaDoc: 'How much one unit cost in Rubles for this subscription',
schemaDoc: 'Price of a single unit in rubles.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true. It's just a price without currency. Because we had additional field there


unitPrice: {
schemaDoc: 'How much one unit cost in Rubles for this subscription',
schemaDoc: 'Price of a single unit in rubles.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schemaDoc: 'Price of a single unit in rubles.',
schemaDoc: 'Price of a single unit.',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants