-
Notifications
You must be signed in to change notification settings - Fork 96
Clarify schemaDoc descriptions across domains #6848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (29)
Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
||
| finishAt: { | ||
| schemaDoc: 'When subscription should be ended', | ||
| schemaDoc: 'Subscription end date and time.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are so much docs, which can be assessed and understood in two ways
|
|
||
| unitPrice: { | ||
| schemaDoc: 'How much one unit cost in Rubles for this subscription', | ||
| schemaDoc: 'Price of a single unit in rubles.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not true. It's just a price without currency. Because we had additional field there
|
|
||
| unitPrice: { | ||
| schemaDoc: 'How much one unit cost in Rubles for this subscription', | ||
| schemaDoc: 'Price of a single unit in rubles.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| schemaDoc: 'Price of a single unit in rubles.', | |
| schemaDoc: 'Price of a single unit.', |



Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69027ad0f424832e81f2e98fba66eb25
Summary by CodeRabbit
Documentation
Bug Fixes
Improvements