feat(registry-importer,news-greenhouse): DOMA-12984 api new urls#7283
Merged
vovaaxeapolla merged 3 commits intomainfrom Mar 5, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis pull request updates git submodule commit pointers in three locations ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Confidence Score: 2/5
Last reviewed commit: bc077e7 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/registry-importer`:
- Line 1: Block merging this PR until the submodule SHA for
apps/registry-importer (1d79ea10b0009b4b9a60e024894a44be442e4c9c) is explicitly
verified as stable: add a draft/hold label or CI gate, require the author to
confirm the intended commit SHA and provide verification (e.g., git show output,
signed tag, or internal release note) in the PR description or a follow-up
comment, and update CI/merge checks to fail unless the verification comment or
approved checklist entry referencing that exact SHA is present.
apps/registry-importer
Outdated
| @@ -1 +1 @@ | |||
| Subproject commit a6fe11be47f72994b6cde5941aaf47501eacbd63 | |||
| Subproject commit 1d79ea10b0009b4b9a60e024894a44be442e4c9c | |||
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Confirm submodule URL for apps/registry-importer
echo "=== Step 1: Submodule URL ==="
git config -f .gitmodules --get submodule.apps/registry-importer.url 2>&1 || echo "Submodule config not found"
# 2) Confirm the gitlink SHA currently pointed to by this PR
echo -e "\n=== Step 2: Current gitlink SHA ==="
git ls-tree HEAD apps/registry-importer 2>&1 || echo "No gitlink found at HEAD"
# 3) Verify the SHA exists on the submodule remote
echo -e "\n=== Step 3: Checking if SHA exists on remote ==="
SUBMODULE_URL="$(git config -f .gitmodules --get submodule.apps/registry-importer.url 2>&1)" || echo "Could not get URL"
if [ -n "${SUBMODULE_URL:-}" ]; then
TARGET_SHA="1d79ea10b0009b4b9a60e024894a44be442e4c9c"
echo "Checking for SHA: $TARGET_SHA"
git ls-remote "$SUBMODULE_URL" | grep -i "$TARGET_SHA" || echo "Target SHA not found on remote"
else
echo "Skipping remote check due to missing URL"
fi
# 4) (Optional) Show commit subject from remote by shallow-fetching metadata
echo -e "\n=== Step 4: Commit info (if accessible) ==="
if [ -n "${SUBMODULE_URL:-}" ]; then
tmpdir="$(mktemp -d)"
trap "rm -rf $tmpdir" EXIT
git -C "$tmpdir" init -q 2>&1 || true
git -C "$tmpdir" remote add origin "$SUBMODULE_URL" 2>&1 || true
git -C "$tmpdir" fetch --depth=1 origin "$TARGET_SHA" 2>&1 || echo "Could not fetch shallow commit"
git -C "$tmpdir" show --no-patch --pretty=fuller FETCH_HEAD 2>&1 || echo "Could not show commit"
else
echo "Skipping commit fetch due to missing URL"
fiRepository: open-condo-software/condo
Length of output: 926
🏁 Script executed:
#!/bin/bash
set -euo pipefail
SUBMODULE_URL="git@github.com:open-condo-software/condo-registry-importer.git"
TARGET_SHA="1d79ea10b0009b4b9a60e024894a44be442e4c9c"
echo "=== Attempt 1: Full ls-remote output (first 20 refs) ==="
git ls-remote "$SUBMODULE_URL" 2>&1 | head -20 || echo "Failed to access remote"
echo -e "\n=== Attempt 2: Check if SHA is reachable via any ref ==="
git ls-remote "$SUBMODULE_URL" | wc -l
echo -e "\n=== Attempt 3: Search for exact SHA anywhere in refs ==="
git ls-remote "$SUBMODULE_URL" | grep -c "$TARGET_SHA" || echo "0 matches found"
echo -e "\n=== Attempt 4: List remote branches and tags (https fallback) ==="
# Try HTTPS URL as fallback in case SSH is the issue
git ls-remote "https://github.com/open-condo-software/condo-registry-importer.git" 2>&1 | head -30 || echo "HTTPS access also failed"Repository: open-condo-software/condo
Length of output: 370
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== Checking .gitmodules file ==="
cat .gitmodules 2>/dev/null | grep -A 3 "registry-importer" || echo "No .gitmodules found"
echo -e "\n=== Checking git config ==="
git config --get-regexp "registry-importer" || echo "No config found"
echo -e "\n=== List all submodules ==="
git config --file .gitmodules --name-only --get-regexp path | head -20
echo -e "\n=== Check current HEAD and recent commits ==="
git log --oneline -n 10 2>&1 | head -15
echo -e "\n=== Check if apps/registry-importer directory exists in working tree ==="
if [ -d "apps/registry-importer" ]; then
echo "Directory exists"
ls -la apps/registry-importer/ 2>&1 || echo "Cannot list contents"
else
echo "Directory does not exist in working tree (expected for submodule)"
fi
echo -e "\n=== Verify this is a gitlink (submodule pointer) ==="
file apps/registry-importer 2>&1 || echo "File command failed"
</script>Repository: open-condo-software/condo
Length of output: 1632
🌐 Web query:
condo-registry-importer 1d79ea10b0009b4b9a60e024894a44be442e4c9c github
💡 Result:
- A GitHub repository search for
condo-registry-importerreturns 0 results (no public repo with that exact name found). [1] - A GitHub code search for the SHA
1d79ea10b0009b4b9a60e024894a44be442e4c9ccan’t be validated from the public web view because GitHub requires you to sign in to use code search. [2]
If you share the expected owner/org (e.g., org/repo) or a direct URL, I can narrow it down further.
Sources: [1], [2]
Block merge until this submodule SHA is explicitly verified as stable.
Line 1 moves apps/registry-importer to commit 1d79ea10b0009b4b9a60e024894a44be442e4c9c, but this PR is described as using unstable API URLs. The target repository is private and the SHA cannot be validated from public sources. Gate this behind a draft/hold policy and verify the target SHA is intentional and release-safe before merge.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/registry-importer` at line 1, Block merging this PR until the submodule
SHA for apps/registry-importer (1d79ea10b0009b4b9a60e024894a44be442e4c9c) is
explicitly verified as stable: add a draft/hold label or CI gate, require the
author to confirm the intended commit SHA and provide verification (e.g., git
show output, signed tag, or internal release note) in the PR description or a
follow-up comment, and update CI/merge checks to fail unless the verification
comment or approved checklist entry referencing that exact SHA is present.
toplenboren
approved these changes
Mar 4, 2026
Member
toplenboren
left a comment
toplenboren
left a comment
There was a problem hiding this comment.
Ok, but in domains/greendom/constants.js it is best to add a comment indicating that v2: .../v1/... is OK
dkoviazin
approved these changes
Mar 5, 2026
vovaaxeapolla
force-pushed
the
feat/registry-importer-news-greenhouse/DOMA-12984/new-urls
branch
from
7528ec9 to
bc077e7
Compare
vovaaxeapolla
force-pushed
the
feat/registry-importer-news-greenhouse/DOMA-12984/new-urls
branch
from
bc077e7 to
01901f2
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
vovaaxeapolla
deleted the
feat/registry-importer-news-greenhouse/DOMA-12984/new-urls
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not intended to be merged right now. New api urls are unstable
Summary by CodeRabbit