hotfix(condo): DOMA-13023 reduce space in hint#7316
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughRefactors inline hint styles to CSS modules across ticket components, removes per-component style props, adds Apollo Client cache eviction on TicketPropertyHint form submission, updates a callcenter submodule pointer, and reduces paragraph spacing in rich-content styling. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Form as BaseTicketPropertyHintForm
participant Apollo as ApolloClient.cache
participant Queries as QueryLayer
User->>Form: submit()
Form->>Apollo: evict(id: 'ROOT_QUERY', fieldNames: [...TicketPropertyHint, meta...])
Apollo->>Apollo: garbageCollect()
Apollo->>Queries: mark queries stale / trigger refetch on next access
Queries->>User: provide updated data (on refetch)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Stylelint (17.3.0)apps/condo/domains/ticket/components/BaseTicketForm/index.module.cssConfigurationError: Could not find "stylelint-config-rational-order". Do you need to install the package or use the "configBasedir" option? apps/condo/domains/ticket/hooks/useTicketPropertyHintTableColumns.module.cssConfigurationError: Could not find "stylelint-config-rational-order". Do you need to install the package or use the "configBasedir" option? Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/condo/domains/ticket/hooks/useTicketPropertyHintTableColumns.module.css`:
- Around line 1-8: The .ticket-property-hint-content CSS rule contains a
duplicate property "white-space: inherit"; remove the redundant occurrence so
the block only declares white-space once (keep a single "white-space: inherit"
in the .ticket-property-hint-content rule) to satisfy stylelint
duplicate-property checks and maintain the same layout behavior.
In `@packages/ui/src/components/style/mixins/rich-content.less`:
- Around line 24-26: Revert the global paragraph spacing change inside the
.condo-rich-content() mixin (so Markdown/style.less and Input/style.less keep
their original spacing) and instead apply the tighter margin only within the
ticket-specific selector introduced in this PR (e.g., add a rule like
.ticket-hint .condo-rich-content() { p { margin: 0 0 `@condo-global-spacing-8`; }
} or the appropriate ticket-hint class used in your ticket CSS module); update
the mixin usage so .condo-rich-content() remains generic and the reduced spacing
is confined to the ticket-hint CSS module/class.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4f02327d-e1e9-4b86-aa10-8cfe2781b595
📒 Files selected for processing (12)
apps/callcenterapps/condo/domains/ticket/components/BaseTicketForm/index.module.cssapps/condo/domains/ticket/components/BaseTicketForm/index.tsxapps/condo/domains/ticket/components/ClientCard/TabContent.module.cssapps/condo/domains/ticket/components/TicketPropertyHint/BaseTicketPropertyHintForm.tsxapps/condo/domains/ticket/components/TicketPropertyHint/TicketPropertyHintCard.tsxapps/condo/domains/ticket/components/TicketPropertyHint/TicketPropertyHintContent.tsxapps/condo/domains/ticket/hooks/useTicketPropertyHintTableColumns.module.cssapps/condo/domains/ticket/hooks/useTicketPropertyHintTableColumns.tsxapps/condo/pages/ticket/[id]/index.module.cssapps/condo/pages/ticket/[id]/index.tsxpackages/ui/src/components/style/mixins/rich-content.less
apps/condo/domains/ticket/hooks/useTicketPropertyHintTableColumns.module.css
Outdated
Show resolved
Hide resolved
…les for ticket property hints
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
* hotfix(condo): DOMA-12023 reduce space in hint * hotfix(condo): DOMA-13023 update subproject commit and adjust CSS styles for ticket property hints (cherry picked from commit d9318d9)
4 participants
Summary by CodeRabbit
Style
Improvements
Chores