feat: OpenCraft sandbox footer. #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sandbox-footer #6 +/- ##
=================================================
Coverage ? 94.04%
=================================================
Files ? 14
Lines ? 84
Branches ? 18
=================================================
Hits ? 79
Misses ? 5
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xitij2000
requested changes
Jun 17, 2025
Comment on lines
+1
to
+6
| $opencraft-green: #0F1F24 !default; | ||
| $footer-text-color: #ffffff !default; | ||
| $footer-link-hover-color: #8CAEB5 !default; | ||
| $opencraft-footer-link-color: #5EFFC9 !default; | ||
| $opencraft-accent: #203D44 !default; | ||
|
|
There was a problem hiding this comment.
I don't think colors should be hardcoded here. This should be moved to the theme.
There was a problem hiding this comment.
I think this was accidentally committed.
| <div className={"text-center text-md-left"}><small>© OpenCraft 2025 | edX and Open edX® are trademarks of edX Inc</small></div> | ||
| </footer> | ||
| </> | ||
| ) |
There was a problem hiding this comment.
This should be in separate component file and imported here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a prototype footer for our sandboxes.
JIRA tickets: https://tasks.opencraft.com/browse/STAR-4200
Screenshots:
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.
Testing instructions:
Author notes and concerns:
I'm waiting on Axim to provide the 'powered by Open edX' logos, which are pre-hosted. The trademark page's links to these assets are broken and I've reported it to Eden, who has promised to provide me with updated links. I could add the asset but it's not yet clear where it would best be hosted.