refactor!: rename the PHD to Launchpad stack#15
Merged
gabor-boros merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
Member
|
@gabor-boros The changes look good! I found a few references to picasso-harmony-drydock.opencraft.com, which I'm guessing we will also want to update. Then there are also these files that still have phd in their name:
|
Member
|
Looks good @gabor-boros 👍
|
mtyaka
approved these changes
Mar 11, 2026
kaustavb12
approved these changes
Mar 12, 2026
| STRAIN_REPOSITORY_BRANCH: ${{ inputs.STRAIN_REPOSITORY_BRANCH }} | ||
| PICASSO_VERSION: ${{ inputs.PICASSO_VERSION }} | ||
| PHD_CLI_VERSION: ${{ inputs.PHD_CLI_VERSION }} | ||
| LAUNCHPAD_CLI_VERSION: ${{ inputs.LAUNCHPAD_CLI_VERSION }} |
Member
There was a problem hiding this comment.
We can remove this from here and from build.yml and from inputs above, as well as, from the cluster templates.
| TERRAFORM_SECRETS: | ||
| required: true | ||
| PHD_DOCKER_REGISTRY_CREDENTIALS: | ||
| LAUNCHPAD_DOCKER_REGISTRY_CREDENTIALS: |
Member
There was a problem hiding this comment.
Nit: Would it be a good idea to do away with LAUNCHPAD_ from all these secrets? There will be less disruption, in case we decide to rename this stack again (hopefully never).
SE-6590 Signed-off-by: Gabor Boros <gabor@opencraft.com>
SE-6590 Signed-off-by: Gabor Boros <gabor@opencraft.com>
gabor-boros
force-pushed
the
gabor/rename-stack
branch
from
d095d41 to
9f6e643
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the PHD stack to launchpad stack. The current repository name and generated repositories should be adjusted as well once this PR is merged.
SE-6590