Skip to content

refactor: remove argo workflows#9

Merged
gabor-boros merged 3 commits intomainfrom
gabor-remove-argo-workflows
Feb 18, 2026
Merged

refactor: remove argo workflows#9
gabor-boros merged 3 commits intomainfrom
gabor-remove-argo-workflows

Conversation

@gabor-boros
Copy link
Copy Markdown
Collaborator

Description

Remove the Argo Workflows UI and configures RBAC for argoCD only.

Testing

  1. Remove the resources manually with kubectl that are removed by this PR
  2. In an existing cluster, run the install command

SE-6524

SE-6524

Signed-off-by: Gabor Boros <gabor@opencraft.com>
Copy link
Copy Markdown
Member

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just added a couple of clarifications.

  • I tested this: Tested in a cluster
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • Added to the Code Drift project board (for backports)

Comment on lines +52 to +55
p, role:developer, applicationsets, create, *, allow
p, role:developer, applicationsets, update, *, allow
p, role:developer, applicationsets, delete, *, allow
p, role:developer, applicationsets, action/*, *, allow
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabor-boros I am not very familiar with ApplicationSet, so just wanted to flag this for verification from your end that write access to application set is appropriate for developer role. I say this because this doc mentions:

ApplicationSet controller may also be used to allow developers (without access to the Argo CD namespace) to independently create Applications without cluster-administrator intervention.

This sort of implies to me that application sets are something an admin is meant to create which can then be used by developers to create applications.

Comment on lines +57 to +58
p, role:developer, projects, create, *, allow
p, role:developer, projects, update, *, allow
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabor-boros I am not sure we want to give developers write access to projects. I am thinking in the context of the axim cluster, where we plan to create a "superuser" for that project.

Here, the developer role as configured now, seems the most appropriate "superuser" role since I don't want this "superuser" to have access to things like gpg keys, certificates, etc. I am wondering if write access projects is required here at all or should it be reserved for the actual "cluster admin" role.

@gabor-boros gabor-boros merged commit fba6ab9 into main Feb 18, 2026
0 of 2 checks passed
@gabor-boros gabor-boros deleted the gabor-remove-argo-workflows branch February 18, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants