Skip to content

Conversation

@kaustavb12
Copy link
Member

Description

The PR cherry-picks eshe specific customizations on to sumac.2

Other information

Private Ref : BB-9546

navinkarkera and others added 15 commits June 8, 2025 12:22
* feat: hide some menu options

* chore: update dev config

(cherry picked from commit 9303505)
This change adds support for logging in and registering a new account using the
browser. This can be useful for cases where the only way to log into the
instance is via a custom third-party auth provider.

(cherry picked from commit 60675bd)
This change adds support for pull to refresh when the course list is empty.

(cherry picked from commit 03deef3)
@tecoholic
Copy link
Member

@kaustavb12 The eshe-mvp branch reports

This branch is 19 commits ahead of, 72 commits behind openedx/openedx-app-android:main.

However, there are only 15 commits in this PR. There seems to be 4 commits missing?

@kaustavb12
Copy link
Member Author

@tecoholic

Out of the 19 commits in the eshe-mvp branch, 6 are merge commits, which I have omitted in the new branch.

I have also added 2 new commits:

  1. bump version of a github action
  2. remove credentials of client's env

That makes it 19 - 6 + 2 = 15 commits

Please let me know if I should have included the merge commits.

@tecoholic
Copy link
Member

@kaustavb12 👍 I see. Thank you that makes sense.

  • I tested this: Test the APKs that they redirect to the right sites & confirmed that the necessary commits have been ported over to sumac.2 branch.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@kaustavb12 kaustavb12 merged commit d5a2c49 into eshe-mvp-release/sumac.2 Jun 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants