docs: update to reflect the latest dev practices#2
Merged
Conversation
tecoholic
force-pushed
the
tecoholic/update-readme-for-ulmo
branch
from
ca6eab8 to
33a3fd1
Compare
Member
|
@tecoholic The changes look good to me. It seems the tests are failing but I don't think in this case it should block merge, since it looks more like the CI itself is broken. Before merging, please create a relevant follow-up ticket to get this resolved, or else note the problem in the compatibility spreadsheet for Sam to work through later. 👍 |
Member
Author
|
@Kelketek Thank you. I have added the test status to the excel sheet and noted that the CI is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates the README.rst.
JIRA: Link to JIRA ticket
Dependencies: NA
Merge deadline: NA
Testing instructions:
Follow the latest instructions in the README.
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: N/A