Open
Conversation
razvand
requested changes
Mar 16, 2024
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Improve the commit messages:
- Use present tense.
- Add a description message for each commit.
SorinAlexB
force-pushed
the
vagrant_sorin
branch
from
abbf5b3 to
e219a35
Compare
SorinAlexB
force-pushed
the
vagrant_sorin
branch
3 times, most recently
from
f88a867 to
754b4cb
Compare
Creating toml files for commons, zeratool_lib, vulnerability_analytics, opencrs_dataset, wiki, nic_c_test_suite and awesome-binary-analysis repos Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
Create toml file for signature_generation module Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
Using python 3.12 will result into an error because distutils is no longer supported. Downgrading to python 3.10 will solve this issue. Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
Create toml file for vulnerability_detection Signed-off-by: Sorin Birchi <sb.birchi.sorin@gmail.com>
SorinAlexB
force-pushed
the
vagrant_sorin
branch
from
754b4cb to
9d0704f
Compare
razvand
requested changes
Mar 25, 2024
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Make sure files don't have trailing white spaces. Make sure they are newline-ended. Make sure there are no conflict residues.
Make sure the commit messages wrap at 72 characters.
| args: | ||
| chdir: /home/{{ username }}/attack_surface_approximation/ | ||
|
|
||
| <<<<<<< HEAD:playbooks-opencrs/attack-surface-approx.yml |
There was a problem hiding this comment.
This is an unsolved conflict. Take care of it.
| # args: | ||
| # chdir: /home/{{ username }}/vulnerability_analytics/ | ||
| # executable: /bin/bash | ||
| # become: yes No newline at end of file |
| chdir: /home/{{ username }}/dataset/ | ||
|
|
||
| executable: /bin/bash | ||
| become: yes No newline at end of file |
| args: | ||
| chdir: /home/{{ username }}/automatic_exploit_generation/ | ||
| executable: /bin/bash | ||
| become: yes No newline at end of file |
| chdir: /home/{{ username }}/vulnerability_detection/ | ||
|
|
||
| - name: Build vulnerability_detection docker container | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
This is an unsolved conflict. Take care of it.
Comment on lines
+10
to
+12
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lack of yaml files for modules and issues with docker group. The problems were solved by updating the playbooks with new yaml files and updating the master yaml file.