Skip to content

No Password Reset for Deleted Users #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
Jan 20, 2025
Merged

No Password Reset for Deleted Users #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ca03e7
fix(views): password reset deleted users;
JVickery-TBS Jan 20, 2025
a017dde
feat(misc): changelog;
JVickery-TBS Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/187.canada.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not allow password reset for Deleted users.
6 changes: 6 additions & 0 deletions ckan/views/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,12 @@ def post(self) -> Response:
.format(id))

for user_obj in user_objs:
# (canada fork only): skip deleted users
# TODO: upstream contrib?
if user_obj.state == 'deleted':
log.info('Cannot reset password for deleted user: {}'.format(
user_obj.name))
continue
log.info(u'Emailing reset link to user: {}'
.format(user_obj.name))
try:
Expand Down
Loading