Skip to content

New Translations and Template Code for Delete Resource Confirmation#1556

Merged
JVickery-TBS merged 7 commits intomasterfrom
feature/handle-dataset-resource-validation
Feb 10, 2025
Merged

New Translations and Template Code for Delete Resource Confirmation#1556
JVickery-TBS merged 7 commits intomasterfrom
feature/handle-dataset-resource-validation

Conversation

@JVickery-TBS
Copy link
Contributor

feat(templates): new code;

  • Update code and add translations.

req: open-data/ckan#189

- Update code and add translations.
- Added change log file.
@JVickery-TBS
Copy link
Contributor Author

annnnd once again, we can ignore the flake8 and pyright in this one...

- Better handling of resource validation errors.
- Handle all dataset errors in resource actions.
- Remove unhelpful comments.
- Remove unused import.
- Added to the change log file.
@JVickery-TBS
Copy link
Contributor Author

@wardi okay so some bigger changes in this one now. Because of the issues with the dataset_errors variable in open-data/ckan#189 I have just done the ckanext-scheming templating in our plugin here. It is pretty much a copy of the errors.html template from ckanext-scheming, but just rigged to work with the new ErrorDict from the open-data/ckan PR.

- `dataset_errors` -> `resource_validation_errors`
- Improved scheming errors template.
@JVickery-TBS JVickery-TBS requested a review from wardi February 7, 2025 18:41
@JVickery-TBS JVickery-TBS merged commit c00cfd5 into master Feb 10, 2025
4 of 6 checks passed
@JVickery-TBS JVickery-TBS deleted the feature/handle-dataset-resource-validation branch February 10, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants