Skip to content

Add f41 image building and modify weekly cache workflow.#752

Open
nszczygl9 wants to merge 8 commits intomainfrom
nsz-build-fedora
Open

Add f41 image building and modify weekly cache workflow.#752
nszczygl9 wants to merge 8 commits intomainfrom
nsz-build-fedora

Conversation

@nszczygl9
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. List any dependencies that are required for this change.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the MIT license for my code changes.
  • I have not introduced any 3rd party components incompatible with MIT.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflows to add Fedora 41 image builds and adjust the weekly cached image workflow to focus on cache generation.

Changes:

  • Added a new reusable workflow to build the Fedora 41 Docker image.
  • Wired the Fedora 41 image build into the main PR workflow.
  • Modified the weekly cached images workflow to remove image tagging/pushing/signing logic and add a Fedora 41 cache build.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/dls-weekly-cached-images.yaml Removes image-tagging/publish/sign steps and adds a Fedora 41 cache build job.
.github/workflows/dls-pr-workflow.yaml Adds a job that calls the new Fedora 41 image build workflow.
.github/workflows/dls-build-fedora41-images.yaml Introduces a reusable workflow to build the Fedora 41 image using Buildx and GHCR cache.
Comments suppressed due to low confidence (1)

.github/workflows/dls-weekly-cached-images.yaml:11

  • action-type is required for manual dispatch, but it’s no longer referenced anywhere in this workflow (the previous if: inputs.action-type == 'weekly' gates were removed). Either reintroduce conditional behavior based on inputs.action-type or remove the input to avoid confusion.
  workflow_dispatch:
    inputs:
      action-type:
        description: 'Choose if this run is weekly build or cache update'
        required: true
        type: choice

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 8, 2026 12:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/dls-weekly-cached-images.yaml:14

  • workflow_dispatch input action-type is required but is never referenced anywhere in this workflow, so it adds UI friction without affecting behavior. Either remove this input entirely, or use it to conditionally run weekly publishing vs cache-only updates (e.g., gate any push/sign steps or skip jobs when action-type == 'cache').
  workflow_dispatch:
    inputs:
      action-type:
        description: 'Choose if this run is weekly build or cache update'
        required: true
        type: choice
        options:
          - 'weekly'
          - 'cache'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 8, 2026 13:25
@nszczygl9 nszczygl9 marked this pull request as ready for review April 8, 2026 13:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings April 9, 2026 08:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nszczygl9 nszczygl9 enabled auto-merge (squash) April 9, 2026 09:19
@nszczygl9 nszczygl9 disabled auto-merge April 9, 2026 11:12
@nszczygl9 nszczygl9 enabled auto-merge (squash) April 9, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants