Skip to content

Add component test of augmentation parameters and add minor fixes #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+434 −82
Open

Add component test of augmentation parameters and add minor fixes #1353

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b16a3b7
use providerRender function instead of RequiredProviders
romanowska Sep 26, 2025
b3148d2
update mocks
romanowska Sep 26, 2025
17f2cda
update NumberParameter interface min value to allow null
romanowska Sep 26, 2025
f902a06
update minValue type to number | null
romanowska Oct 2, 2025
0f0fd86
update aria labels
romanowska Oct 2, 2025
6db31d2
add and update component tests
romanowska Oct 2, 2025
43a96f4
update condition for values update
romanowska Oct 2, 2025
8c17244
fix getStep fn
romanowska Oct 3, 2025
091ccf4
fix(tests): Align mocks and behavior in component tests
MarkRedeman Oct 7, 2025
0f289aa
Merge branch 'main' into kromano/add_augs_tests
romanowska Oct 16, 2025
66e5efd
Merge branch 'kromano/add_augs_tests' of https://github.com/open-edge…
romanowska Oct 16, 2025
059a5d3
add missing awaits
romanowska Oct 16, 2025
760a7b5
remove unnecessary props
romanowska Oct 16, 2025
681e007
fixed resolved merge conflict
romanowska Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web_ui/src/core/configurable-parameters/dtos/configuration.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface ParameterBaseDTO {
interface NumberParameterDTO extends ParameterBaseDTO {
type: 'int' | 'float';
value: number;
min_value: number;
min_value: number | null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When min_value can be null?

Copy link
Contributor Author

@romanowska romanowska Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for Random Affine Maximum shear degree, Gaussian noise mean

max_value: number | null;
default_value: number;
}
Expand Down
2 changes: 1 addition & 1 deletion web_ui/src/core/configurable-parameters/services/configuration.interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ interface ParameterBase {
export interface NumberParameter extends ParameterBase {
type: 'int' | 'float';
value: number;
minValue: number;
minValue: number | null;
maxValue: number | null;
defaultValue: number;
}
Expand Down
2 changes: 1 addition & 1 deletion ...rain-model-dialog/advanced-settings/data-management/filters/filters-options.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const FilterOption: FC<FilterOptionProps> = ({ option, onOptionChange }) => {
<Flex gap={'size-200'} gridColumn={'2/3'}>
<NumberField
aria-label={`Change ${name}`}
minValue={minValue}
minValue={minValue ?? undefined}
maxValue={maxValue ?? undefined}
step={1}
value={value}
Expand Down
11 changes: 8 additions & 3 deletions ...oject-models/train-model-dialog/advanced-settings/ui/number-parameter-field.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const getStep = ({
type,
}: {
step?: number;
minValue: number;
minValue: number | null;
maxValue: number | null;
type: NumberParameter['type'];
}): number => {
Expand All @@ -36,6 +36,10 @@ const getStep = ({
return type === 'int' ? DEFAULT_INT_STEP : DEFAULT_FLOAT_STEP;
}

if (minValue === null) {
return type === 'int' ? 0 : 0.0;
}

return getFloatingPointStep(minValue, maxValue);
};

Expand Down Expand Up @@ -63,13 +67,14 @@ export const NumberParameterField: FC<NumberGroupParamsProps> = ({
setParameterValue(value);
}, [value]);

if (maxValue === null) {
if (maxValue === null || minValue === null) {
return (
<NumberField
aria-label={`Change ${name}`}
step={fieldStep}
value={parameterValue}
minValue={minValue}
minValue={minValue === null ? undefined : minValue}
maxValue={maxValue === null ? undefined : maxValue}
onChange={handleValueChange}
isDisabled={isDisabled}
/>
Expand Down
8 changes: 4 additions & 4 deletions ...roject-models/train-model-dialog/advanced-settings/ui/range-parameter-field.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,21 @@ export const RangeParameterField: FC<RangeParameterFieldProps> = ({
const handleRangeChange = (inputValue: RangeValue<number>): void => {
const { start, end } = inputValue;
// Prevent start and end from being equal
if (end - start > fieldStep) {
if (end - start >= fieldStep) {
setParameterValue({ start, end });
}
};

const handleNumberChange = (start: number, end: number): void => {
// Prevent start and end from being equal
if (end - start > fieldStep) {
if (end - start >= fieldStep) {
setParameterValue({ start, end });
onChange([start, end]);
}
};

return (
<Flex gap={'size-100'}>
<Flex gap={'size-100'} aria-label={name}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC flex does not have aria-label, could u please double check it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't. updated

<NumberField
isQuiet
step={fieldStep}
Expand All @@ -90,7 +90,7 @@ export const RangeParameterField: FC<RangeParameterFieldProps> = ({
step={fieldStep}
flex={1}
isDisabled={isDisabled}
aria-label={`Change ${name} range value`}
aria-label={`Change ${name} value`}
UNSAFE_className={isDisabled ? '' : classes.rangeSlider}
/>
<NumberField
Expand Down
28 changes: 13 additions & 15 deletions ...nts/project-models/train-model-dialog/advanced-settings/ui/range-parameter-field.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Copyright (C) 2022-2025 Intel Corporation
// LIMITED EDGE SOFTWARE DISTRIBUTION LICENSE

import { fireEvent, render, screen } from '@testing-library/react';
import { fireEvent, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';

import { RequiredProviders } from '../../../../../../../test-utils/required-providers-render';
import { providersRender as render } from '../../../../../../../test-utils/required-providers-render';
import { RangeParameterField } from './range-parameter-field.component';

describe('RangeParameterField', () => {
Expand All @@ -18,17 +18,15 @@ describe('RangeParameterField', () => {

const renderApp = ({ value = defaultValue, isDisabled = false }: { value?: number[]; isDisabled?: boolean }) => {
return render(
<RequiredProviders featureFlags={{ FEATURE_FLAG_NEW_CONFIGURABLE_PARAMETERS: true }}>
<RangeParameterField
defaultValue={defaultValue}
value={value}
onChange={onChange}
name={name}
type={'array'}
isDisabled={isDisabled}
step={0.001}
/>
</RequiredProviders>
<RangeParameterField
defaultValue={defaultValue}
value={value}
onChange={onChange}
name={name}
type={'array'}
isDisabled={isDisabled}
step={0.001}
/>
);
};

Expand All @@ -37,7 +35,7 @@ describe('RangeParameterField', () => {

expect(screen.getByLabelText(`Change ${name} start range value`)).toBeInTheDocument();
expect(screen.getByLabelText(`Change ${name} end range value`)).toBeInTheDocument();
expect(screen.getByLabelText(`Change ${name} range value`)).toBeInTheDocument();
expect(screen.getByLabelText(`Change ${name} value`)).toBeInTheDocument();
});

it('calls onChange when start value changes', async () => {
Expand Down Expand Up @@ -85,7 +83,7 @@ describe('RangeParameterField', () => {
expect(screen.getByLabelText(`Change ${name} start range value`)).toBeDisabled();
expect(screen.getByLabelText(`Change ${name} end range value`)).toBeDisabled();

const slider = screen.getByLabelText(`Change ${name} range value`);
const slider = screen.getByLabelText(`Change ${name} value`);

expect(slider).toHaveClass('A-RCEa_is-disabled');
});
Expand Down
2 changes: 1 addition & 1 deletion ...header/active-learning-configuration/training-settings/required-annotations.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const RequiredAnnotations: FC<RequiredAnnotationsProps> = ({
<NumberField
step={1}
value={numberOfRequiredAnnotations}
minValue={requiredImagesAutoTrainingConfig.minValue}
minValue={requiredImagesAutoTrainingConfig.minValue ?? undefined}
maxValue={requiredImagesAutoTrainingConfig.maxValue ?? undefined}
onChange={handleRequiredAnnotationsChange}
label={'Number of required annotations'}
Expand Down
Loading
Loading