Skip to content

Conversation

@ivanzati
Copy link
Contributor

πŸ“ Description

Test default token to delete package version workflow

✨ Type of Change

Select the type of change your PR introduces:

  • [x ] 🐞 Bug fix – Non-breaking change which fixes an issue
  • πŸš€ New feature – Non-breaking change which adds functionality
  • πŸ”¨ Refactor – Non-breaking change which refactors the code base
  • πŸ’₯ Breaking change – Changes that break existing functionality
  • πŸ“š Documentation update
  • πŸ”’ Security update
  • πŸ§ͺ Tests

πŸ§ͺ Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • βœ… Tested manually
  • πŸ€– Run automated end-to-end tests

βœ… Checklist

Before submitting the PR, ensure the following:

  • πŸ” PR title is clear and meaningful
  • ✍️ PR description clearly explains the changes and their reason
  • πŸ“ I have linked the PR to the corresponding GitHub Issues, if any
  • πŸ’¬ I have commented my code, especially in hard-to-understand areas
  • πŸ“„ I have made corresponding changes to the documentation
  • βœ… I have added tests that prove my fix is effective or my feature works

@ivanzati ivanzati requested a review from kamillipka as a code owner November 21, 2025 10:31
Copilot AI review requested due to automatic review settings November 21, 2025 10:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the cleanup-old-packages workflow to use the default GITHUB_TOKEN instead of a custom GHCR_CLEANUP_TOKEN secret for package deletion operations. This change is being tested to verify if the default token has sufficient permissions for GitHub Container Registry cleanup tasks.

Key Changes:

  • Replaced GHCR_CLEANUP_TOKEN with GITHUB_TOKEN across all cleanup operations
  • Added error handling with continue-on-error: true to prevent workflow failures during testing

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ivanzati ivanzati changed the title [WIP] Test default token in cleanup-old-packages wrkflw Set default token in cleanup-old-packages wrkflw Dec 11, 2025
@ivanzati ivanzati enabled auto-merge December 11, 2025 12:09
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a short inline comment here why do we need this permission - otherwise OpenSSF action will flag an issue (example - https://github.com/open-edge-platform/geti/security/code-scanning/204)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, have added inline comment

@ivanzati ivanzati added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 46359eb Dec 11, 2025
15 checks passed
@ivanzati ivanzati deleted the ivanzati/coe-cleanup-old-packages-wrkflw branch December 11, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants