-
Notifications
You must be signed in to change notification settings - Fork 46
Set default token in cleanup-old-packages wrkflw #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the cleanup-old-packages workflow to use the default GITHUB_TOKEN instead of a custom GHCR_CLEANUP_TOKEN secret for package deletion operations. This change is being tested to verify if the default token has sufficient permissions for GitHub Container Registry cleanup tasks.
Key Changes:
- Replaced
GHCR_CLEANUP_TOKENwithGITHUB_TOKENacross all cleanup operations - Added error handling with
continue-on-error: trueto prevent workflow failures during testing
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| packages: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a short inline comment here why do we need this permission - otherwise OpenSSF action will flag an issue (example - https://github.com/open-edge-platform/geti/security/code-scanning/204)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, have added inline comment
π Description
Test default token to delete package version workflow
β¨ Type of Change
Select the type of change your PR introduces:
π§ͺ Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
β Checklist
Before submitting the PR, ensure the following: