Update UI deps pt. 1 #864
Open
Update UI deps pt. 1 #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveChooN
requested review from
MarkRedeman,
camiloHimura,
dwesolow,
jpggvilaca,
pplaskie and
romanowska
as code owners
ActiveChooN
commented
Jul 21, 2025
|
|
||
| fireEvent.click(screen.getByRole('button', { name: /Choose annotation dataset/ })); | ||
| const picker = screen.getByRole('button', { name: /Choose annotation dataset/ }); | ||
| const selectTester = testUtilUser.createTester('Select', { root: picker }); |
There was a problem hiding this comment.
According to the documentation, this is the recommended way to interact with the picker https://react-spectrum.adobe.com/react-spectrum/Picker.html#testing
jpggvilaca
reviewed
Jul 21, 2025
| @@ -1 +1 @@ | |||
| 22.12.0 | |||
| 22.17.0 No newline at end of file | |||
There was a problem hiding this comment.
Question: why this change?
ActiveChooN
commented
Jul 21, 2025
| const testUtilUser = new User(); | ||
|
|
||
| beforeAll(() => { | ||
| simulateDesktop(); |
There was a problem hiding this comment.
This function sets the view's height and width. It is required due to the picker's virtualization.
|
Can we divide this into:
(1 PR each) And for now maybe let's leave react-spectrum out. If we need to update our code then this is not so safe as updating minor versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Updated deps for UI, fixed tests related to react-spectrum update
#832
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: