Skip to content

Add ruff #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sovrasov merged 7 commits into from
Oct 30, 2024
Merged

Add ruff #215

sovrasov merged 7 commits into from
Oct 30, 2024

Conversation

@ashwinvaidya17
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 commented Oct 30, 2024 •
edited
Loading

What does this PR do?

  • Replaces isort and black with ruff in pre-commit hook.
  • All the rules are disabled. The idea is to slowly enable them across the repo.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@ashwinvaidya17
add ruff
2179174 
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17
remove black from pre-commit tests
b178029 
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review October 30, 2024 12:58
@ashwinvaidya17 ashwinvaidya17 marked this pull request as draft October 30, 2024 13:00
@ashwinvaidya17
ignore unused import for tests
3e3b1f7 
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17
add annotations
4a35930 
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17
remove strict
8658fcd 
Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review October 30, 2024 14:23
@sovrasov sovrasov merged commit 955118b into open-edge-platform:master Oct 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovrasov sovrasov sovrasov approved these changes

@eugene123tw eugene123tw Awaiting requested review from eugene123tw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashwinvaidya17 @sovrasov