Skip to content

Conversation

@sovrasov
Copy link
Member

What does this PR do?

  • uses nanobind to construct the bindings
  • covers classification
  • bindings are optional to avoid unnecessary side-effects in other projects that use model_api/cpp

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sovrasov sovrasov requested a review from mgumowsk January 10, 2025 11:18
@github-actions github-actions bot added cpp C++ related changes python python related changes build Related to build scripts labels Jan 10, 2025
mgumowsk
mgumowsk previously approved these changes Jan 10, 2025
@github-actions github-actions bot added the tests Related to tests label Jan 13, 2025
@sovrasov
Copy link
Member Author

Had to do weird stuff in cpp CI workflows, because g++11 throws unexpected warnings on nanobind code, while warning compile flags are global in the existing CMake script.

@sovrasov sovrasov requested a review from mgumowsk January 14, 2025 13:07
@sovrasov sovrasov added this pull request to the merge queue Jan 15, 2025
Merged via the queue into open-edge-platform:master with commit e97b12c Jan 15, 2025
16 checks passed
@sovrasov sovrasov deleted the vs/nanobind branch January 15, 2025 10:44
@sovrasov sovrasov added this to the 0.2.6 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to build scripts cpp C++ related changes python python related changes tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants