Merge ModelBase into ImageModel #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example works, but probably some missing parts.
sovrasov
reviewed
Apr 4, 2025
as opposed to ModelBase as it was. So first it was ImageModel: ModelBase. Then ModelBase merged into ImageModel now rename ImageModel to BaseModel
sovrasov
approved these changes
Apr 8, 2025
Merged
via the queue into
open-edge-platform:master
with commit Apr 8, 2025
2294c06
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in attempting to reduce complexity.
First by adding complexity by merging the model base and image model. The second step step would be to extract as much of the logic and properties into separate modules.