Skip to content

Conversation

@RHeckerIntel
Copy link
Contributor

Initial import from POC

Contains:

  1. Detection, instance segmentation, semantic segmentation
  2. Support for sync, async, batch
  3. Tiling support for detection

Closes #298

@RHeckerIntel RHeckerIntel requested a review from a team as a code owner June 9, 2025 10:09
@RHeckerIntel RHeckerIntel changed the title Rhecker/model api refactor Import CPP refactor from POC Jun 9, 2025
@github-actions github-actions bot added tests Related to tests cpp C++ related changes build Related to build scripts samples labels Jun 9, 2025
@RHeckerIntel RHeckerIntel force-pushed the rhecker/model_api_refactor branch from 15019f2 to 08fef00 Compare June 9, 2025 10:49
@RHeckerIntel RHeckerIntel force-pushed the rhecker/model_api_refactor branch from 08fef00 to 7cbc2c7 Compare June 9, 2025 11:05
@RHeckerIntel RHeckerIntel force-pushed the rhecker/model_api_refactor branch from 6bb2c3d to ba9141d Compare June 9, 2025 11:23
@sovrasov
Copy link
Member

Thanks Ronald, impressive work. Overall, I'm ok with the changes, keeping in mind that async public API is hard to implement and it is unclear why do we need it at all. For now, I propose to delete it, and keep async features private (to emulate batch inference for instance). Now, inferAsync brings only confusion to the model interface, as not all the models and backends can support it.

@github-actions github-actions bot added the docs Related to documentation label Jun 13, 2025
@github-actions github-actions bot added the python python related changes label Jun 13, 2025
@RHeckerIntel RHeckerIntel force-pushed the rhecker/model_api_refactor branch from 5780302 to b9192de Compare June 13, 2025 12:40
@RHeckerIntel RHeckerIntel merged commit 25e44e7 into open-edge-platform:feature/cpp_refactoring Jun 13, 2025
11 checks passed
@RHeckerIntel RHeckerIntel deleted the rhecker/model_api_refactor branch June 13, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to build scripts cpp C++ related changes docs Related to documentation python python related changes samples tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants