-
Notifications
You must be signed in to change notification settings - Fork 19
Import CPP refactor from POC #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RHeckerIntel
merged 10 commits into
open-edge-platform:feature/cpp_refactoring
from
RHeckerIntel:rhecker/model_api_refactor
Jun 13, 2025
Merged
Import CPP refactor from POC #302
RHeckerIntel
merged 10 commits into
open-edge-platform:feature/cpp_refactoring
from
RHeckerIntel:rhecker/model_api_refactor
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15019f2 to
08fef00
Compare
08fef00 to
7cbc2c7
Compare
6bb2c3d to
ba9141d
Compare
sovrasov
reviewed
Jun 12, 2025
Member
|
Thanks Ronald, impressive work. Overall, I'm ok with the changes, keeping in mind that async public API is hard to implement and it is unclear why do we need it at all. For now, I propose to delete it, and keep async features private (to emulate batch inference for instance). Now, |
sovrasov
reviewed
Jun 12, 2025
sovrasov
reviewed
Jun 13, 2025
5780302 to
b9192de
Compare
25e44e7
into
open-edge-platform:feature/cpp_refactoring
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial import from POC
Contains:
Closes #298