Refactor - Implement Classification #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added multiclass classification
github-actions
bot
added
tests
Had to set ov::batch(model, 1);
Sometimes the value for bool is "True" This evaluation from string is only added in openvino 2025.1.0
RHeckerIntel
force-pushed
the
rhecker/model_api_refactor_classification
branch
from
10cd895 to
58c7110
Compare
sovrasov
reviewed
Jun 16, 2025
orig_width and height are stored in rt_info anyway. Serialization is a separate step and it _should_ output the same model
sovrasov
approved these changes
Jun 17, 2025
sovrasov
merged commit d5890e8
into
open-edge-platform:feature/cpp_refactoring
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Classification Model into the refactor feature branch
Also managed to fix issue that the serialization gives slightly different output. The cause was a missing ov::set_batch(model, 1);
This mirrored the issue in instance and semantic segmentation and so also enabled those tests
Closes #294
Closes #293
Closes #292