Skip to content

[ITEP-85509] Add UUID checker for scheme.py#1021

Open
dmytroye wants to merge 10 commits intomainfrom
ITEP-85509/add-uuid-checker
Open

[ITEP-85509] Add UUID checker for scheme.py#1021
dmytroye wants to merge 10 commits intomainfrom
ITEP-85509/add-uuid-checker

Conversation

@dmytroye
Copy link
Member

@dmytroye dmytroye commented Feb 16, 2026

📝 Description

This PR adds UUID format validation support to SceneScape's schema validation system. The change introduces a custom format checker for UUID validation in the SchemaValidation class, enabling JSON schemas to enforce UUID format constraints on string fields.

Changes:

  • Added uuid module import to support UUID validation
  • Implemented a custom checkUuid format checker that validates UUID strings (versions 1-5) using Python's standard uuid.UUID parser
  • Registered the checker with jsonschema's FormatChecker to enable "format": "uuid" constraints in JSON schemas

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@dmytroye dmytroye requested a review from Copilot February 16, 2026 11:11
@dmytroye dmytroye self-assigned this Feb 16, 2026
@dmytroye dmytroye marked this pull request as ready for review February 16, 2026 11:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds UUID format validation support to SceneScape's schema validation system. The change introduces a custom format checker for UUID validation in the SchemaValidation class, enabling JSON schemas to enforce UUID format constraints on string fields.

Changes:

  • Added uuid module import to support UUID validation
  • Implemented a custom checkUuid format checker that validates UUID strings (versions 1-5) using Python's standard uuid.UUID parser
  • Registered the checker with jsonschema's FormatChecker to enable "format": "uuid" constraints in JSON schemas

@dmytroye
Copy link
Member Author

dmytroye commented Feb 16, 2026

UUID checker will be required after scene-data.schema.json update in Tracker Service will be introduced in PR #968

@dmytroye dmytroye marked this pull request as draft February 16, 2026 13:08
@dmytroye dmytroye marked this pull request as ready for review February 16, 2026 14:10
@dmytroye dmytroye marked this pull request as draft February 16, 2026 14:25
@dmytroye dmytroye requested a review from Copilot February 16, 2026 14:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

@dmytroye dmytroye requested a review from Copilot February 16, 2026 15:04
@dmytroye dmytroye marked this pull request as ready for review February 16, 2026 15:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants