Conversation
This reverts commit 0c5959e.
…orm/scenescape into docker_gha_cache
…orm/scenescape into docker_gha_cache
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI build pipeline to speed up Docker image builds by enabling remote layer caching via GHCR, scoped per branch while allowing reads from main’s cache.
Changes:
- Adds optional GHCR-backed cache flags to Docker image builds via
common.mk. - Configures CI workflows to enable caching via environment variables and authenticates to GHCR before building.
- Uses per-branch cache tags (with fallback reads from
main) to improve cache hit rates across PR runs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
common.mk |
Adds conditional Docker build cache arguments intended for GHCR-backed caching in CI. |
.github/workflows/tests-bat.yml |
Enables caching env vars and logs into GHCR before BAT-related builds. |
.github/workflows/tests-all.yml |
Enables caching env vars and logs into GHCR before the various test suites’ builds. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit f719640.
tdorauintc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added GHCR as Docker cache.
Each branch has it's own cache to speed up consecutive builds for PRs.
There's also read access to main branch so that the first build will also be faster.
Branches only update cache of their own.
These changes have no impact for local builds so they won't impact development.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: