Skip to content

Conversation

@dmytroye
Copy link
Member

@dmytroye dmytroye commented Dec 1, 2025

📝 Description

This PR fixes a flaky test related to distance MSOCE (Mean Squared Orthogonal Cumulative Error) metrics by adding synchronization to ensure the tracker completes processing before collecting tracked data. The fix moves the distance-msoce test from the broken tests list back to the active metric tests suite.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@dmytroye dmytroye changed the base branch from main to release-2025.2 December 1, 2025 12:23
@dmytroye dmytroye self-assigned this Dec 1, 2025
@dmytroye dmytroye requested a review from Copilot December 1, 2025 13:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a flaky test related to distance MSOCE (Mean Squared Orthogonal Cumulative Error) metrics by adding synchronization to ensure the tracker completes processing before collecting tracked data. The fix moves the distance-msoce test from the broken tests list back to the active metric tests suite.

Key Changes:

  • Added a waitForComplete() call to ensure tracker finishes processing before joining
  • Re-enabled the distance-msoce test by moving it from broken tests to metric tests

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/system/metric/tc_distance_thresh.py Added waitForComplete() synchronization call before tracker join to ensure consistent baseline MSOCE values
tests/Makefile Moved distance-msoce test from broken-tests target to _metric-tests target

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmytroye dmytroye removed their assignment Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants