-
Notifications
You must be signed in to change notification settings - Fork 35
[ITEP-74332] Add healthcheck to controller #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds HTTP-based health check functionality to the scene controller service, bringing it in line with other services (manager and autocalibration) that already have health checks implemented.
Changes:
- Adds an HTTP server with
/healthzand/healthendpoints to the controller - Configures health check probes in both Docker Compose and Kubernetes deployment manifests
- Implements a command-line argument
--healthcheck-portto enable/configure the health check server
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| controller/src/controller-cmd | Implements HTTP health check server with request handler and threading support |
| sample_data/docker-compose-dl-streamer-example.yml | Adds Docker health check configuration using the new endpoint |
| kubernetes/scenescape-chart/templates/scene-controller/deployment.yaml | Replaces placeholder readiness probe with HTTP-based health check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
π Description
Adds a healthcheck to scene controller.
Manager and autocalibration already have healthchecks implemented.
β¨ Type of Change
Select the type of change your PR introduces:
π§ͺ Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
β Checklist
Before submitting the PR, ensure the following: