Skip to content

Conversation

@jakubsikorski
Copy link
Contributor

πŸ“ Description

Adds a healthcheck to scene controller.

Manager and autocalibration already have healthchecks implemented.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • πŸš€ New feature – Non-breaking change which adds functionality
  • πŸ”¨ Refactor – Non-breaking change which refactors the code base
  • πŸ’₯ Breaking change – Changes that break existing functionality
  • πŸ“š Documentation update
  • πŸ”’ Security update
  • πŸ§ͺ Tests
  • πŸš‚ CI

πŸ§ͺ Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • βœ… Tested manually
  • πŸ€– Ran automated end-to-end tests

βœ… Checklist

Before submitting the PR, ensure the following:

  • πŸ” PR title is clear and descriptive
  • πŸ“ For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • πŸ’¬ I have commented my code, especially in hard-to-understand areas
  • πŸ“„ I have made corresponding changes to the documentation
  • βœ… I have added tests that prove my fix is effective or my feature works

@jakubsikorski jakubsikorski self-assigned this Jan 22, 2026
@jakubsikorski jakubsikorski requested a review from Copilot January 22, 2026 11:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds HTTP-based health check functionality to the scene controller service, bringing it in line with other services (manager and autocalibration) that already have health checks implemented.

Changes:

  • Adds an HTTP server with /healthz and /health endpoints to the controller
  • Configures health check probes in both Docker Compose and Kubernetes deployment manifests
  • Implements a command-line argument --healthcheck-port to enable/configure the health check server

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
controller/src/controller-cmd Implements HTTP health check server with request handler and threading support
sample_data/docker-compose-dl-streamer-example.yml Adds Docker health check configuration using the new endpoint
kubernetes/scenescape-chart/templates/scene-controller/deployment.yaml Replaces placeholder readiness probe with HTTP-based health check

@jakubsikorski jakubsikorski requested a review from Copilot January 22, 2026 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

@jakubsikorski jakubsikorski marked this pull request as ready for review January 22, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants