ADR proposals #4918
Open
ADR proposals #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Architectural Decision Records (ADRs) to document key technical decisions made in the Geti Tune UI project. The documentation covers five major architectural areas: API client implementation, state management approach, testing strategy, UI package structure, and feature-based architecture.
- Establishes ADR documentation framework with an index of all decisions
- Documents technical choices for API integration, state management, testing, UI components, and code organization
- Provides implementation examples and rationale for each architectural decision
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/docs/adr/README.md | Creates ADR index with links to five architectural decision records |
| application/ui/docs/adr/001-api-client.md | Documents decision to use openapi-fetch with React Query for type-safe API communication |
| application/ui/docs/adr/002-state-management.md | Documents decision to use React Context API with custom providers for client state |
| application/ui/docs/adr/003-testing-strategy.md | Documents three-tier testing pyramid using Vitest and Playwright |
| application/ui/docs/adr/004-ui-packages.md | Documents decision to use Adobe React Spectrum as the component library |
| application/ui/docs/adr/005-feature-structure.md | Documents feature-based architecture for organizing code by domain |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Docker Image Sizes
|
📊 Test coverage report
|
camiloHimura
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist