Skip to content

Conversation

jpggvilaca
Copy link
Contributor

@jpggvilaca jpggvilaca commented Oct 20, 2025

Summary

  • Integrate model statistics endpoint (latency and throughput so far)
  • Add second data collection policy (was on TODO)
  • Remove SearchField from models page (to be added on later iterations)
  • Update component test
Screenshot 2025-10-20 at 16 14 31 Screenshot 2025-10-20 at 16 01 20

How to test

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@jpggvilaca jpggvilaca requested a review from a team as a code owner October 20, 2025 14:23
@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 14:23
@jpggvilaca jpggvilaca added the Geti Tune UI Issues related to Geti Tune Studio UI label Oct 20, 2025
@github-actions github-actions bot added the TEST Any changes in tests label Oct 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates model statistics functionality by implementing a real-time metrics endpoint and expanding the data collection policies to include confidence threshold-based capturing. It also removes the SearchField component from the models page.

  • Implements real-time latency and throughput metrics using API polling
  • Adds confidence threshold data collection policy alongside the existing fixed rate policy
  • Updates component tests to reflect the new dual policy structure

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
application/ui/tests/inference.spec.ts Updates test to include confidence threshold policy alongside fixed rate policy
application/ui/src/features/models/page-header.component.tsx Removes SearchField component and import
application/ui/src/features/inference/aside/graphs.component.tsx Replaces mock data with real API metrics for latency and throughput graphs
application/ui/src/features/inference/aside/data-collection.component.tsx Adds confidence threshold policy UI controls and refactors to handle dual policies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 37 to 38
const ratePolicy = policies[0] as FixedRatePolicy | undefined;
const confidencePolicy = policies[1] as ConfidenceThresholdPolicy | undefined;
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded array indices (0 and 1) make the code fragile. Consider finding policies by type instead of relying on array position order.

Suggested change
const ratePolicy = policies[0] as FixedRatePolicy | undefined;
const confidencePolicy = policies[1] as ConfidenceThresholdPolicy | undefined;
const ratePolicy = policies.find(
(policy) => policy.type === 'fixed_rate'
) as FixedRatePolicy | undefined;
const confidencePolicy = policies.find(
(policy) => policy.type === 'confidence_threshold'
) as ConfidenceThresholdPolicy | undefined;

Copilot uses AI. Check for mistakes.

Copy link

github-actions bot commented Oct 20, 2025

Docker Image Sizes

Image Size
geti-tune-pr-4929 1.5G
geti-tune-sha-6d81c66 1.5G

Copy link

📊 Test coverage report

Metric Coverage
Lines 38.3%
Functions 35.5%
Branches 84.2%
Statements 38.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Tune UI Issues related to Geti Tune Studio UI TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant