-
Notifications
You must be signed in to change notification settings - Fork 462
Integrate model statistics #4929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates model statistics functionality by implementing a real-time metrics endpoint and expanding the data collection policies to include confidence threshold-based capturing. It also removes the SearchField component from the models page.
- Implements real-time latency and throughput metrics using API polling
- Adds confidence threshold data collection policy alongside the existing fixed rate policy
- Updates component tests to reflect the new dual policy structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
application/ui/tests/inference.spec.ts | Updates test to include confidence threshold policy alongside fixed rate policy |
application/ui/src/features/models/page-header.component.tsx | Removes SearchField component and import |
application/ui/src/features/inference/aside/graphs.component.tsx | Replaces mock data with real API metrics for latency and throughput graphs |
application/ui/src/features/inference/aside/data-collection.component.tsx | Adds confidence threshold policy UI controls and refactors to handle dual policies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
const ratePolicy = policies[0] as FixedRatePolicy | undefined; | ||
const confidencePolicy = policies[1] as ConfidenceThresholdPolicy | undefined; |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded array indices (0 and 1) make the code fragile. Consider finding policies by type instead of relying on array position order.
const ratePolicy = policies[0] as FixedRatePolicy | undefined; | |
const confidencePolicy = policies[1] as ConfidenceThresholdPolicy | undefined; | |
const ratePolicy = policies.find( | |
(policy) => policy.type === 'fixed_rate' | |
) as FixedRatePolicy | undefined; | |
const confidencePolicy = policies.find( | |
(policy) => policy.type === 'confidence_threshold' | |
) as ConfidenceThresholdPolicy | undefined; |
Copilot uses AI. Check for mistakes.
Docker Image Sizes
|
📊 Test coverage report
|
Summary
How to test
Checklist