Skip to content

Conversation

jpggvilaca
Copy link
Contributor

Summary

  • Add annotation label unit tests

How to test

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 14:23
@jpggvilaca jpggvilaca requested a review from a team as a code owner October 20, 2025 14:23
@jpggvilaca jpggvilaca added the Geti Tune UI Issues related to Geti Tune Studio UI label Oct 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the AnnotationLabels component and includes a defensive code change to handle labels without names.

  • Adds 8 test cases covering rendering, interactions, and edge cases
  • Adds null-safety check for label names in width calculation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
annotation-labels.component.tsx Adds conditional check to prevent calculating width when label.name is undefined/null
annotation-labels.component.test.tsx New test file with comprehensive coverage including empty labels, single/multiple labels, interactions, zoom scaling, and positioning

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Oct 20, 2025

Docker Image Sizes

Image Size
geti-tune-pr-4930 1.5G
geti-tune-sha-f126e5e 1.5G

Copy link

github-actions bot commented Oct 20, 2025

📊 Test coverage report

Metric Coverage
Lines 40.0%
Functions 36.2%
Branches 84.7%
Statements 40.0%

@jpggvilaca jpggvilaca merged commit d512bfa into develop Oct 21, 2025
28 checks passed
@jpggvilaca jpggvilaca deleted the jvilaca/annotation-unit-tests branch October 21, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Tune UI Issues related to Geti Tune Studio UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants