Secondary toolbar with Accept/Delete actions #4931
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a secondary toolbar with Accept/Delete actions in the media preview interface, enhancing the annotation workflow by allowing users to submit or delete annotations directly from the preview screen.
Key changes:
- Added Submit/Close buttons and delete functionality to the secondary toolbar
- Implemented user review status indicators (Accept/Search icons) on sidebar media items
- Refactored component architecture to pass dataset items through the component tree
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
application/ui/src/index.css |
Added new color variable --coral-shade-1 and z-index styling for modal overlays |
application/ui/src/features/dataset/media-preview/sidebar-items/sidebar-media-item.module.scss |
Defined styles for Accept and Search icon containers with distinctive background colors |
application/ui/src/features/dataset/media-preview/sidebar-items/sidebar-media-item.component.tsx |
Created new component to display media items with review status icons |
application/ui/src/features/dataset/media-preview/sidebar-items/sidebar-items.component.tsx |
Refactored to accept items as props and removed local state management |
application/ui/src/features/dataset/media-preview/secondary-toolbar/secondary-toolbar.component.tsx |
Enhanced with Submit/Close buttons, delete functionality, and automatic navigation to next item |
application/ui/src/features/dataset/media-preview/media-preview.component.tsx |
Updated to fetch dataset items and pass them to child components |
application/ui/src/features/dataset/media-preview/annotator-buttons.component.tsx |
Removed file as functionality moved to secondary toolbar |
application/ui/src/features/dataset/gallery/media-item.module.scss |
Removed background color from floating containers |
application/ui/src/features/dataset/gallery/media-item.component.tsx |
Added className prop and data attributes to floating containers |
application/ui/src/features/dataset/gallery/gallery.module.scss |
Created new stylesheet to apply background to gallery floating containers |
application/ui/src/features/dataset/gallery/gallery.component.tsx |
Applied new styles and removed unnecessary key prop |
application/ui/src/features/annotator/annotation-actions-provider.component.tsx |
Added isUserReviewed field, error handling for unannotated items, and retry logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tion/ui/src/features/dataset/media-preview/secondary-toolbar/secondary-toolbar.component.tsx
Show resolved
Hide resolved
...tion/ui/src/features/dataset/media-preview/secondary-toolbar/secondary-toolbar.component.tsx
Outdated
Show resolved
Hide resolved
...tion/ui/src/features/dataset/media-preview/secondary-toolbar/secondary-toolbar.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/annotator/annotation-actions-provider.component.tsx
Show resolved
Hide resolved
Docker Image Sizes
|
📊 Test coverage report
|
camiloHimura
force-pushed
the
ccolora11/4556-accept-decline
branch
from
c5dd653 to
911747f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2025-10-20.at.16.46.31.mov
How to test
Checklist