issue-97 Add content for End-to-End Attacks#80
Open
davidxbors wants to merge 12 commits intoopen-education-hub:mainfrom
Open
issue-97 Add content for End-to-End Attacks#80davidxbors wants to merge 12 commits intoopen-education-hub:mainfrom
davidxbors wants to merge 12 commits intoopen-education-hub:mainfrom
Conversation
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
3 times, most recently
from
22f024b to
3c6481e
Compare
Add slides for Chapter 10: End to End Attacks Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
3c6481e to
1ab61cb
Compare
added 4 commits
July 6, 2024 16:29
Added reading content and media. Updated titles to respect openedu format. Changed imgs paths. Signed-off-by: David Bors <borsdavid@proton.me>
Add drills to this session. Signed-off-by: David Bors <borsdavid@proton.me>
Fixed markdownlint errors. Signed-off-by: David Bors <borsdavid@proton.me>
Fix checkpatch errors from drills/ files. Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
4b8fa10 to
8d13e91
Compare
Fixed True Positive spellcheck errors. Some errors were FPs so not errors, and were left like they were. Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
376ad8e to
9fb33eb
Compare
Fixed missing license from a .py file. Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
e239101 to
54311ed
Compare
davidxbors
changed the title
Fix markdownlint erros for drills md files. Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
34b1715 to
91c6a4a
Compare
Fix linter errors from Superlinter. Signed-off-by: David Bors <borsdavid@proton.me>
davidxbors
force-pushed
the
add-end-to-end-content-to-new-format
branch
from
91c6a4a to
cecf382
Compare
added 2 commits
July 7, 2024 13:51
Move files to the correct directory to respect the chapter. Signed-off-by: David Bors <borsdavid@proton.me>
Changed config and tested it. Signed-off-by: David Bors <borsdavid@proton.me>
RaduNichita
approved these changes
Jul 9, 2024
Collaborator
|
Please solve the conflicts and then you can merge. The content is good, thanks a lot |
carrrina
changed the title
carrrina
changed the title
carrrina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Added the contents for chapter 10 - end to end attacks.
I tried to fix all workflow errors.
Checkpatch fails because of a file I removed in the meantime. (It was a file I used to automatically convert something in the markdown).
Spellcheck fails on False Positives.
The Superlinter errors are either FPs (the 2 markdown errors) or errors derived from
Ccode.The problem here is that we use two linters for the same language, with different rules. (checkpatch vs superlinter)
Imo, we should fix this for the future.
I didn't know if we do squash merges here or not so I made granular commits. If needed I'll squash them before merging.