Generated digidocPINVOKE.cs contained bad library name without lib prefix in macOS #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efix in macOS. This commit fixes the generated code to global::System.Runtime.InteropServices.DllImport("libdigidoc_csharp",...
WE2-1073
Signed-off-by: Sven Mitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE2-1073
Signed-off-by: Sven Mitt [email protected]
How to test:
Install swig and all dependencies. Use macOS and run
cmake --preset macos -DCMAKE_BUILD_TYPE=RelWithDebInfo && cmake --build --preset macos
Test result with:
grep DllImport ./build/macos/src/csharp/digidocPINVOKE.cs | sed -e 's/, Entry.*/.../g'|sort|uniq
Should be:
[global::System.Runtime.InteropServices.DllImport("digidoc"...
[global::System.Runtime.InteropServices.DllImport("libdigidoc_csharp"...
[global::System.Runtime.InteropServices.DllImport("libdigidoc_csharp"...