Skip to content

Conversation

4nd3r
Copy link

@4nd3r 4nd3r commented Aug 13, 2025

Fixes #685.

Signed-off-by: Ander Punnar [email protected]

@4nd3r
Copy link
Author

4nd3r commented Aug 14, 2025

Wait with merge a bit, need to sort out few build failures:
https://github.com/4nd3r/libdigidocpp/actions

Weird that they showed up now, didn't happen before 🤷

Will rebase later.

@4nd3r 4nd3r marked this pull request as draft August 14, 2025 12:22
@4nd3r 4nd3r force-pushed the debian branch 2 times, most recently from da3dbc7 to ebb56aa Compare August 14, 2025 17:30
@4nd3r 4nd3r marked this pull request as ready for review August 14, 2025 17:36
@4nd3r
Copy link
Author

4nd3r commented Aug 14, 2025

Looks better now:
https://github.com/4nd3r/libdigidocpp/actions/runs/16972276007

Did few additional small changes:

  • For the sake of consistency, use codenames for both.
  • Adjusted the version string.
  • Use standard /etc/os-release instead of lsb_release.

If codenames for Ubuntšik are not fine, then I'll revert back to numbers.

Sadly, there's no better way to define the strategy matrix, because the previously proposed approach didn't behave correctly for Debian arches.

Ubuntu is based on Debian, so the entire build process for Debian is
pretty much the same as it is for Ubuntu. Instead of creating a separate
job, just hook into the Ubuntu job, for now.

Additional small changes:
* For the sake of consistency, use codenames for both.
* Adjusted the version string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian?
2 participants