Skip to content

Add contributors to metadata files and show on benchmark details page#145

Merged
siddharth-krishna merged 8 commits intomainfrom
daniele/add_contributors
Apr 11, 2025
Merged

Add contributors to metadata files and show on benchmark details page#145
siddharth-krishna merged 8 commits intomainfrom
daniele/add_contributors

Conversation

@danielelerede-oet
Copy link
Member

Hi @siddharth-krishna I added the contributors to metadata files as discussed. I only have 2 doubts:

  1. Temoa Project is listed as contributor for Temoa benchmarks, though they actually don't know about our project, so I'm not quite sure we should mention them as "contributors"
  2. the merge_metdata.py script is not taking Contributor as an entry for the summary table, is it intentional?

@vercel
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solver-benchmark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 9:55am

Copy link
Member

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Daniele!

  1. Let's use the URLs to the GH repo for Temoa Project and Jump-dev platform
  2. It's not intentional, it's a To Do. I can add that to this PR, and then perhaps @jacek-oet could help us by adding support on the website to display the Contributor(s) on the benchmark details page? Perhaps it can, for now, be a separate paragraph below the Short description, that looks like e.g.
    Contributor(s)/Source: https://github.com/temoa-project/temoa; Daniele Lerede, Open Energy Transition
    image

@danielelerede-oet
Copy link
Member Author

@siddharth-krishna everything should be ready in agreement to what we discussed earlier!

Copy link
Member

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks Daniele! I'll update the metadata merging script now.

@jacek-oet could you please add task 2 above to your list? You can push directly to this PR branch. It would be good if URLs in the Contributor(s)/Source field appeared on the website as hyperlinks. Thanks!

Copy link
Member

@siddharth-krishna siddharth-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacek-oet , but I'm afraid the deployment doesn't work for me:
image

Can you reproduce the error? Otherwise I can try building locally.
Edit: works locally. Let's hope it also works after merging into main!

@siddharth-krishna siddharth-krishna changed the title Add contributors to metadata files Add contributors to metadata files and show on benchmark details page Apr 11, 2025
@siddharth-krishna siddharth-krishna merged commit fc08571 into main Apr 11, 2025
4 checks passed
@siddharth-krishna siddharth-krishna deleted the daniele/add_contributors branch April 11, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants