Implement reference benchmark#147
Merged
KristijanFaust-OET merged 3 commits intomainfrom Apr 10, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KristijanFaust-OET
force-pushed
the
reference-benchmark
branch
from
666e367 to
acdc157
Compare
KristijanFaust-OET
force-pushed
the
reference-benchmark
branch
from
acdc157 to
e794366
Compare
siddharth-krishna
approved these changes
Apr 10, 2025
Member
siddharth-krishna
left a comment
siddharth-krishna
left a comment
There was a problem hiding this comment.
Thanks Kristijan, this looks good! A minor request in comments. I don't have time to test it but I'm sure you did. :)
runner/run_benchmarks.py
Outdated
| # Add required fields to reference metrics | ||
| reference_metrics["size"] = "reference" | ||
| reference_metrics["solver"] = "highs-binary" | ||
| reference_metrics["solver_version"] = get_highs_binary_version() |
Member
There was a problem hiding this comment.
Could we call this once outside the loop and share the result for every iteration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces optional periodic reference benchmark runs.
If testing before merging this to
main, you should add something like:to the startup-script.sh after cloning the benchmark repo.