Benchmarks: add TIMES NZ, IE, and eTIMES-EU benchmarks#96
Benchmarks: add TIMES NZ, IE, and eTIMES-EU benchmarks#96siddharth-krishna merged 16 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
added TIMES-NZ benchmarks @siddharth-krishna , I'm updating the slides, too |
siddharth-krishna
left a comment
There was a problem hiding this comment.
Thanks, Daniele. I requested some minor changes. I'll merge #99 first, so it would be good if you could also indicate the sizes, or at least which ones count as "real" -- I would guess all of them?
|
Hi @siddharth-krishna , I made the changes you asked |
There was a problem hiding this comment.
Hi Daniele, apologies I dropped the ball on this PR and now it's stale and needs to be updated with the main branch (and the info from benchmark_config.yaml needs to be merged into the metadata.yaml file, e.g. URL). Would you have time to do this?
Other remaining TODOs:
- Remove Olex's affiliation
- The 2 new comments I've added inline
Co-authored-by: Siddharth Krishna <siddharth-krishna@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Hi @siddharth-krishna , I've done all the changes, though I was having issues with merging the main branch. The metadata file is completely revised though. If there are any problems I could save the file locally and open a new PR generating the new branch from the current main, let me know please :) |
|
Thanks, @danielelerede-oet . I fixed a syntax error and ran the I didn't see any merge issues. But if you could double check that the diff in https://github.com/open-energy-transition/solver-benchmark/pull/96/files has the latest metadata, that would be great. It looks good to me, but I can't check if the benchmark metadata has been categorized correctly. |
|
@siddharth-krishna everything's fine with the diff. |
siddharth-krishna
left a comment
There was a problem hiding this comment.
Thanks, Daniele, I think with the new website you can have anything in the "Name:" field, it doesn't have to follow the old format of <spatial_res>-<temporal_res>. Please do open a new PR updating all the metadata as you suggest, and we'll double check in that branch that the website continues to work fine.
Hi @siddharth-krishna , Victor's TIMES benchmarks added with metadata (with Contributor line) and update of
benchmark_config.yaml