-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for NPX 2.0 single-shank probes #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bparks13
wants to merge
6
commits into
main
Choose a base branch
from
issue-446-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
30564e5
Add support for NPX 2.0 single-shank probes
bparks13 c41fd25
Add column offsets for left vs. right column electrodes
bparks13 ccfb833
Refactor probe configuration properties for serialization and backwar…
bparks13 af1bd2c
Update invert polarity when loading from a file
bparks13 52c95c3
Address review comments
bparks13 b0fffea
Refactor validation and exception handling in probe configuration cla…
bparks13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.ComponentModel; | ||
| using System.Linq; | ||
|
|
||
| namespace OpenEphys.Onix1.Design | ||
| { | ||
| internal class NeuropixelsV2SingleShankInfo : INeuropixelsV2ProbeInfo | ||
| { | ||
| const int BankDStartIndex = 896; | ||
|
|
||
| enum SingleShankChannelPreset | ||
| { | ||
| BankA, | ||
| BankB, | ||
| BankC, | ||
| BankD, | ||
| None | ||
| } | ||
|
|
||
| public IEnumerable<NeuropixelsV2Electrode> Electrodes { get; init; } | ||
|
|
||
| public NeuropixelsV2SingleShankInfo(NeuropixelsV2SingleShankProbeConfiguration probeConfiguration) | ||
| { | ||
| Electrodes = probeConfiguration.ProbeGroup.ToElectrodes(); | ||
| } | ||
|
|
||
| public Array GetReferenceEnumValues() | ||
| { | ||
| return Enum.GetValues(typeof(NeuropixelsV2SingleShankReference)); | ||
| } | ||
|
|
||
| public Array GetComboBoxChannelPresets() | ||
| { | ||
| return Enum.GetValues(typeof(SingleShankChannelPreset)); | ||
| } | ||
|
|
||
| public Enum CheckForExistingChannelPreset(NeuropixelsV2Electrode[] channelMap) | ||
| { | ||
| if (channelMap.All(e => e.Bank == NeuropixelsV2Bank.A)) | ||
| { | ||
| return SingleShankChannelPreset.BankA; | ||
| } | ||
| else if (channelMap.All(e => e.Bank == NeuropixelsV2Bank.B)) | ||
| { | ||
| return SingleShankChannelPreset.BankB; | ||
| } | ||
| else if (channelMap.All(e => e.Bank == NeuropixelsV2Bank.C)) | ||
| { | ||
| return SingleShankChannelPreset.BankC; | ||
| } | ||
| else if (channelMap.All(e => e.Bank == NeuropixelsV2Bank.D || | ||
| (e.Bank == NeuropixelsV2Bank.C && e.Index >= BankDStartIndex))) | ||
| { | ||
| return SingleShankChannelPreset.BankD; | ||
| } | ||
| else | ||
| { | ||
| return SingleShankChannelPreset.None; | ||
| } | ||
| } | ||
|
|
||
| public NeuropixelsV2Electrode[] GetChannelPreset(Enum channelPreset) | ||
| { | ||
| var preset = (SingleShankChannelPreset)channelPreset; | ||
|
|
||
| return preset switch | ||
| { | ||
| SingleShankChannelPreset.BankA => Electrodes.Where(e => e.Bank == NeuropixelsV2Bank.A).ToArray(), | ||
| SingleShankChannelPreset.BankB => Electrodes.Where(e => e.Bank == NeuropixelsV2Bank.B).ToArray(), | ||
| SingleShankChannelPreset.BankC => Electrodes.Where(e => e.Bank == NeuropixelsV2Bank.C).ToArray(), | ||
| SingleShankChannelPreset.BankD => Electrodes.Where(e => e.Bank == NeuropixelsV2Bank.D || (e.Bank == NeuropixelsV2Bank.C && e.Index >= BankDStartIndex)).ToArray(), | ||
| SingleShankChannelPreset.None => Array.Empty<NeuropixelsV2Electrode>(), | ||
| _ => throw new InvalidEnumArgumentException($"Unknown value of {nameof(SingleShankChannelPreset)}: {channelPreset}") | ||
| }; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 31 additions & 4 deletions
35
OpenEphys.Onix1.Design/NeuropixelsV2eProbeConfigurationDialog.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.