-
Notifications
You must be signed in to change notification settings - Fork 23
refactor: Remove deprecated Dependency Injection code #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: Remove deprecated Dependency Injection code #626
Conversation
Signed-off-by: Kyle Julian <[email protected]>
Summary of ChangesHello @kylejuliandev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring effort to remove the deprecated Dependency Injection package. This change is a direct consequence of the introduction of the new Hosting library in v2.9.0, which supersedes the functionality of the old DI package. By eliminating this obsolete component, the codebase becomes leaner, easier to maintain, and aligns with the updated architectural direction of the project. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 89.89% 92.89% +2.99%
==========================================
Files 77 67 -10
Lines 3168 2857 -311
Branches 364 338 -26
==========================================
- Hits 2848 2654 -194
+ Misses 251 143 -108
+ Partials 69 60 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes the deprecated OpenFeature.DependencyInjection project and its corresponding tests. The changes are primarily file deletions and updates to the solution and project files to remove references to the deprecated project. A key change is in test/OpenFeature.AotCompatibility/OpenFeature.AotCompatibility.csproj, where the project reference has been correctly updated to OpenFeature.Hosting, which is the replacement for the removed dependency injection functionality. The pull request is well-executed and achieves its goal of cleaning up the codebase by removing deprecated code. The changes are correct and I have no further suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
I already deprecated the DI library here: https://www.nuget.org/packages/OpenFeature.DependencyInjection
Please keep the readme and just keep a notice with the deprecation to look for the Hosting package.
This PR
With the release of v2.9.0 and the new Hosting library, we should no longer be publishing new versions of the Dependency Injection package. This package will need to be flagged as deprecated directly in NuGet. This PR removes the unused code and unit tests, and fixes a reference in the AotCompatiability project with a Hosting reference.
Related Issues
Fixes #539
Notes
Follow-up Tasks
How to test