Skip to content

feat: Add FLAGD_BASE_IMAGE build argument to Dockerfile#308

Merged
aepfli merged 2 commits intomainfrom
copilot/modify-dockerfile-base-image
Nov 3, 2025
Merged

feat: Add FLAGD_BASE_IMAGE build argument to Dockerfile#308
aepfli merged 2 commits intomainfrom
copilot/modify-dockerfile-base-image

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

Enables building the testbed image with custom flagd base images for pipeline testing scenarios.

Changes

  • Dockerfile: Added FLAGD_BASE_IMAGE build argument, defaults to ghcr.io/open-feature/flagd:v0.12.9
  • README: Documented build argument usage with examples

Usage

# Default behavior (unchanged)
docker build -f flagd/Dockerfile -t flagd-testbed:latest --target testbed .

# With custom flagd image
docker build -f flagd/Dockerfile \
  --build-arg FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.13.0 \
  -t flagd-testbed:custom --target testbed .

Existing builds and CI workflows continue to work without modification.

Original prompt

This section details on the original issue you should resolve

<issue_title>Allow passing a different base image for flagd in Dockerfile</issue_title>
<issue_description>## Background
Currently, the Dockerfile in the flagd-testbed repository uses a fixed base image for building the testbed image. In order to facilitate testing with custom or pipeline-built flagd images, we need the ability to specify a different base image when building the testbed container.

Proposal

  • Modify the Dockerfile to accept an argument (e.g., FLAGD_BASE_IMAGE) allowing the user to specify a custom base image.
  • Update any relevant documentation to explain how to use this new argument during the build process.

Motivation

This change will enable building the testbed image in the flagd pipelines using a base image created within the same pipeline, supporting more flexible and robust testing scenarios.

Acceptance Criteria

  • The Dockerfile accepts a build argument for the base flagd image
  • Documentation is updated to describe how to use the argument
  • Backwards compatibility is maintained (defaults to current base image if not provided)

Feel free to suggest alternative approaches or raise concerns about the impact on current workflows.</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: aepfli <9987394+aepfli@users.noreply.github.com>
Copilot AI changed the title [WIP] Allow passing a different base image for flagd in Dockerfile Add FLAGD_BASE_IMAGE build argument to Dockerfile Oct 31, 2025
Copilot AI requested a review from aepfli October 31, 2025 12:33
@aepfli aepfli marked this pull request as ready for review October 31, 2025 12:36
@aepfli aepfli requested a review from a team as a code owner October 31, 2025 12:36
@aepfli aepfli changed the title Add FLAGD_BASE_IMAGE build argument to Dockerfile feat: Add FLAGD_BASE_IMAGE build argument to Dockerfile Oct 31, 2025
@aepfli aepfli merged commit 779adad into main Nov 3, 2025
3 of 7 checks passed
@aepfli aepfli deleted the copilot/modify-dockerfile-base-image branch November 17, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow passing a different base image for flagd in Dockerfile

2 participants