Skip to content

feat: Add FLAGD_SYNC_PORT support for in-process providers with backwards compatibility #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add FLAGD_SYNC_PORT support for in-process providers with backwards compatibility #310

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e82f00e
Initial plan
Copilot Nov 3, 2025
fdfce2a
Add FLAGD_SYNC_PORT support for in-process providers with backwards c…
Copilot Nov 3, 2025
0bf3813
Use port option with FLAGD_SYNC_PORT env var instead of creating sync…
Copilot Nov 3, 2025
be7a318
Add test to verify FLAGD_SYNC_PORT takes priority over FLAGD_PORT
Copilot Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion gherkin/config.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Feature: Configuration Test
| --------------------- | ------------------------------ | ------------------------------------------------------------------------------- | ---------------------------- | ----------------------------- | ------------------- |
| resolver | FLAGD_RESOLVER | mode of operation | String - `rpc`, `in-process` | rpc | rpc & in-process |
| host | FLAGD_HOST | remote host | String | localhost | rpc & in-process |
| port | FLAGD_PORT | remote port | int | 8013 (rpc), 8015 (in-process) | rpc & in-process |
| port | FLAGD_PORT (rpc), FLAGD_SYNC_PORT (in-process, FLAGD_PORT as fallback) | remote port | int | 8013 (rpc), 8015 (in-process) | rpc & in-process |
| targetUri | FLAGD_TARGET_URI | alternative to host/port, supporting custom name resolution | string | null | rpc & in-process |
| tls | FLAGD_TLS | connection encryption | boolean | false | rpc & in-process |
| socketPath | FLAGD_SOCKET_PATH | alternative to host port, unix socket | String | null | rpc & in-process |
Expand Down Expand Up @@ -208,6 +208,16 @@ Feature: Configuration Test
| tls | FLAGD_TLS | Boolean | True |
| port | FLAGD_PORT | Integer | 1234 |

@in-process
Scenarios: In-Process Sync Port
| option | env | type | value |
| port | FLAGD_SYNC_PORT | Integer | 1234 |

@in-process @legacy-sync-port
Scenarios: In-Process Legacy Port (backwards compatibility)
| option | env | type | value |
| port | FLAGD_PORT | Integer | 1234 |

@rpc @in-process @targetURI
Scenarios: Target URI
| option | env | type | value |
Expand Down Expand Up @@ -284,6 +294,16 @@ Feature: Configuration Test
| tls | FLAGD_TLS | Boolean | True | False |
| port | FLAGD_PORT | Integer | 1234 | 3456 |

@in-process
Scenarios: In-Process Sync Port
| option | env | type | value | env-value |
| port | FLAGD_SYNC_PORT | Integer | 1234 | 3456 |

@in-process @legacy-sync-port
Scenarios: In-Process Legacy Port (backwards compatibility)
| option | env | type | value | env-value |
| port | FLAGD_PORT | Integer | 1234 | 3456 |

@rpc @in-process @targetURI
Scenarios: Target URI
| option | env | type | value | env-value |
Expand Down Expand Up @@ -329,3 +349,10 @@ Feature: Configuration Test
Scenarios: providerId
| option | env | type | value | env-value |
| providerId | FLAGD_PROVIDER_ID | String | providerId | env-prov |

@in-process
Scenario: FLAGD_SYNC_PORT takes priority over FLAGD_PORT
Given an environment variable "FLAGD_SYNC_PORT" with value "9999"
And an environment variable "FLAGD_PORT" with value "8888"
When a config was initialized
Then the option "port" of type "Integer" should have the value "9999"
Loading