Skip to content

Conversation

@aepfli
Copy link
Member

@aepfli aepfli commented Nov 28, 2025

Removed the in-process sync port scenarios and added a new scenario outline for dedicated config via environment variable with an in-process case.

Removed the in-process sync port scenarios and added a new scenario outline for dedicated config via environment variable with an in-process case.

Signed-off-by: Simon Schrottner <[email protected]>
@aepfli aepfli requested a review from a team as a code owner November 28, 2025 10:05
@gemini-code-assist
Copy link

Summary of Changes

Hello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Gherkin feature tests related to in-process synchronization port configuration. It streamlines the testing approach by removing outdated scenarios and introducing a more comprehensive scenario outline that explicitly covers environment variable-based configuration for in-process resolvers, ensuring clearer and more robust testing of configuration priority.

Highlights

  • Removed Old Scenarios: The previous 'In-Process Sync Port' scenarios, which defined how FLAGD_SYNC_PORT was handled for in-process configurations, have been removed from the feature file.
  • New Scenario Outline Added: A new 'Dedicated Config via Env_var special In-process case' scenario outline has been introduced. This new outline explicitly covers the configuration of in-process sync ports via environment variables, specifically for FLAGD_SYNC_PORT.
  • Clarified Existing Scenario: An existing scenario demonstrating that FLAGD_SYNC_PORT takes priority over FLAGD_PORT has been updated to explicitly specify that it applies to the 'in-process' resolver type, ensuring clearer test context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the in-process sync port scenarios in the Gherkin feature file. The changes improve the tests by making them more specific and robust, particularly by explicitly setting the resolver to in-process where appropriate. The refactoring is well-done. I have one minor suggestion to improve naming consistency.

@aepfli aepfli merged commit 1f6845c into main Nov 28, 2025
3 checks passed
@aepfli aepfli deleted the aepfli-patch-1 branch December 28, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants