-
Notifications
You must be signed in to change notification settings - Fork 89
chore: Add devcontainer support #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: André Silva <[email protected]>
…ions Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
… configuration Signed-off-by: GitHub <[email protected]>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Summary of ChangesHello @askpt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
…out lines Signed-off-by: GitHub <[email protected]>
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great addition to the project! Using a devcontainer will significantly improve the developer onboarding experience and ensure a consistent environment. The configuration looks solid. I have a couple of suggestions to enhance the reproducibility and stability of the devcontainer setup.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: André Silva <[email protected]>
…ration Signed-off-by: GitHub <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow cool, thank you!!!!!!
This PR
This pull request introduces a new development container configuration for the project, making it easier to set up a consistent development environment with all necessary tools and extensions. The configuration uses a Go-based container image, includes useful features and VS Code extensions, and sets up the workspace after container creation.
Development environment setup:
.devcontainer/devcontainer.json
file to define a dev container based on the Go 1.24 image, with GitHub CLI and Docker-in-Docker features enabled.vscode
, required at least 8GB of host memory, and specified a post-create command to initialize git submodules and runmake workspace-init
.