feat: allow null flagSetId Selector, restrict Selector to single key-value-pairs (#1708) #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandraoberaigner
changed the title
guidobrei
reviewed
Oct 9, 2025
dosubot
bot
added
the
size:L
|
This looks like the minimum workable implementation until we decide on a more robust Selector syntax. I'm not sure we even want to document this for now, but IMO it's releasable and will allow us to release something now without regretting it. I'm ready to approve except I agree with @guidobrei 's comment here. |
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
guidobrei
approved these changes
Oct 13, 2025
alexandraoberaigner
force-pushed
the
feat/nullflagsetid
branch
from
792f271 to
af33865
Compare
chrfwow
approved these changes
Oct 13, 2025
toddbaert
approved these changes
Oct 13, 2025
beeme1mr
approved these changes
Oct 14, 2025
|
I'll merge this tomorrow unless I hear objections. |
toddbaert
force-pushed
the
feat/nullflagsetid
branch
from
af33865 to
4b1c229
Compare
…value pair and update/skip tests (open-feature#1708) Until we decide on the Selector syntax, only a single key=value pair is supported Signed-off-by: Alexandra Oberaigner <[email protected]>
toddbaert
force-pushed
the
feat/nullflagsetid
branch
from
4b1c229 to
5afde03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request updates the
Selectorlogic in the flag store to allow selecting flags without a flagSetId (flagSetId=).It also restricts selector expressions to a single key-value pair, and updates / skips related tests. This is a temporary limitation pending a decision on the selector syntax (#1708).
Related Issues
#1708
Follow-up Tasks
TODO: we should decide on the selector syntax
How to test
make run-flagd-selector-demo