Skip to content

Conversation

@toddbaert
Copy link
Member

This PR:

Fixes: #1828

@toddbaert toddbaert requested review from a team as code owners November 27, 2025 20:41
@netlify
Copy link

netlify bot commented Nov 27, 2025

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 0c50598
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/6929e932dbd1dd0007fad073
😎 Deploy Preview https://deploy-preview-1829--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 27, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @toddbaert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for flagd's selector features, which allow for more granular and efficient filtering of flag configurations. The updates cover the core concepts of selectors and flag sets, provide practical guidance for their usage, and include a detailed migration path for existing users. Additionally, it addresses potential troubleshooting scenarios and clarifies the syntax and precedence of selectors across various flagd components.

Highlights

  • New Selector Concepts Documentation: Introduced a new conceptual document explaining flagd's selector features, detailing flag sources, flag sets, metadata reflection, and their decoupling for more flexible flag management.
  • Migration Guide for Flag Sets: Added a comprehensive guide to assist users in transitioning from legacy source-based selector patterns to the new, recommended flag set-based patterns, ensuring backward compatibility.
  • Detailed Selector Syntax Reference: Provided a technical specification for selector syntax, including supported keys like flagSetId and source, precedence rules, and how metadata reflection works.
  • Updated Provider and Sync Configuration Docs: Enhanced existing documentation for provider and sync configurations to reflect the new selector capabilities, including usage examples and precedence for different selector input methods.
  • Troubleshooting for Selector Issues: Expanded the troubleshooting guide with a dedicated section for common selector-related problems, offering debugging steps for issues like no flags returned, wrong flags, or ignored selectors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@toddbaert toddbaert marked this pull request as draft November 27, 2025 20:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds extensive and well-structured documentation for the new selector features, covering concepts, migration, syntax, and troubleshooting. The new documentation is a great addition. I've identified a few minor issues, such as a list numbering error and several instances of trailing whitespace that should be corrected for consistency. More significantly, there's a section on selector precedence in sync-configuration.md that appears to be confusing and potentially incorrect in its context, which I've flagged as a high-severity issue to ensure clarity.

toddbaert and others added 11 commits November 27, 2025 15:46
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@sonarqubecloud
Copy link

@toddbaert toddbaert marked this pull request as ready for review November 28, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCS] Create documentation for selector and related metadata features

2 participants