Skip to content

docs: add PR title and DCO rules to CONTRIBUTING.md#321

Merged
beeme1mr merged 3 commits intoopen-feature:mainfrom
arenko-group:conventional-commits-in-contributing
Feb 14, 2025
Merged

docs: add PR title and DCO rules to CONTRIBUTING.md#321
beeme1mr merged 3 commits intoopen-feature:mainfrom
arenko-group:conventional-commits-in-contributing

Conversation

@treuherz
Copy link
Copy Markdown
Contributor

This PR adds the commit convention to the CONTRIBUTING docs. This caught me out on #320, hopefully this helps the next person!

@treuherz treuherz requested a review from a team as a code owner February 13, 2025 12:45
Copy link
Copy Markdown
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @treuherz, good catch. The requirement is only for the PR title as we squash PRs and use the PR title as the new commit message.

As a follow up, I'll update our GitHub action to post a more helpful message in the PR itself.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (ce4920a) to head (68eb0ef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files          13       13           
  Lines        1372     1372           
=======================================
  Hits         1192     1192           
  Misses        156      156           
  Partials       24       24           
Flag Coverage Δ
e2e 86.88% <ø> (ø)
unit 86.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@treuherz treuherz force-pushed the conventional-commits-in-contributing branch from dab3d5f to 93e091e Compare February 13, 2025 14:04
@treuherz treuherz changed the title docs: add commit message convention to CONTRIBUTING.md docs: add PR title and DCO rules to CONTRIBUTING.md Feb 13, 2025
Signed-off-by: Eli Treuherz <et@arenko.group>
Signed-off-by: Eli Treuherz <et@arenko.group>
@treuherz treuherz force-pushed the conventional-commits-in-contributing branch from 93e091e to e5387f7 Compare February 13, 2025 14:07
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Eli Treuherz <1574403+treuherz@users.noreply.github.com>
@treuherz
Copy link
Copy Markdown
Contributor Author

Thanks for the rapid reivew on this and #320, @beeme1mr

@beeme1mr beeme1mr merged commit c2eb5af into open-feature:main Feb 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants