Skip to content

chore(flagd): Improve grpc logging #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore(flagd): Improve grpc logging #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static void monitorChannelState(
}
}
if (currentState != ConnectivityState.SHUTDOWN) {
log.debug("shutting down grpc channel");
log.debug("continuing to monitor the grpc channel");
// Re-register the state monitor to watch for the next state transition.
monitorChannelState(currentState, channel, onConnectionReady, onConnectionLost);
}
Expand Down
6 changes: 5 additions & 1 deletion .../contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
// instead of logging and throwing here, retain the exception and handle in the
// stream logic below
metadataException = e;
log.debug("Metadata exception: {}", e.getMessage(), e);
}

while (!shutdown.get()) {
Expand All @@ -129,7 +130,10 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB

Throwable streamException = response.getError();
if (streamException != null || metadataException != null) {
log.debug("Exception in GRPC connection");
log.debug(
"Exception in GRPC connection, streamException {}, metadataException {}",
streamException,
metadataException);
if (!writeTo.offer(new QueuePayload(
QueuePayloadType.ERROR, "Error from stream or metadata", metadataResponse))) {
log.error("Failed to convey ERROR status, queue is full");
Expand Down