Skip to content

test(gofeatureflags): adapt current tests with key, or missing properties #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

test(gofeatureflags): adapt current tests with key, or missing properties #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cac85c
fixup: formatting of provider
aepfli Apr 22, 2025
f37a51e
test: attempt to fix gofeatureflag tests
aepfli Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) {
onConfigurationChanged(flagdProviderEvent);
break;
}
// intentional fall through
// intentional fall through
case PROVIDER_READY:
/*
* Sync metadata is used to enrich the context, and is immutable in flagd,
Expand Down
10 changes: 10 additions & 0 deletions .../test/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ void should_throw_an_error_if_endpoint_not_available() {
FlagEvaluationDetails<Boolean> got = client.getBooleanDetails("fail_500", false, this.evaluationContext);
FlagEvaluationDetails<Boolean> want = FlagEvaluationDetails.<Boolean>builder()
.value(false)
.flagKey("fail_500")
.reason(Reason.ERROR.name())
.errorCode(ErrorCode.GENERAL)
.errorMessage("unknown error while retrieving flag fail_500")
Expand All @@ -257,6 +258,7 @@ void should_throw_an_error_if_invalid_api_key() {
FlagEvaluationDetails<Boolean> got = client.getBooleanDetails("fail_401", false, this.evaluationContext);
FlagEvaluationDetails<Boolean> want = FlagEvaluationDetails.<Boolean>builder()
.value(false)
.flagKey("fail_401")
.reason(Reason.ERROR.name())
.errorCode(ErrorCode.GENERAL)
.errorMessage("authentication/authorization error")
Expand All @@ -277,6 +279,7 @@ void should_throw_an_error_if_flag_does_not_exists() {
FlagEvaluationDetails<Boolean> got = client.getBooleanDetails("flag_not_found", false, this.evaluationContext);
FlagEvaluationDetails<Boolean> want = FlagEvaluationDetails.<Boolean>builder()
.value(false)
.flagKey("flag_not_found")
.reason(Reason.ERROR.name())
.errorCode(ErrorCode.FLAG_NOT_FOUND)
.errorMessage("Flag flag_not_found was not found in your configuration")
Expand All @@ -297,6 +300,7 @@ void should_throw_an_error_if_we_expect_a_boolean_and_got_another_type() {
FlagEvaluationDetails<Boolean> got = client.getBooleanDetails("string_key", false, this.evaluationContext);
FlagEvaluationDetails<Boolean> want = FlagEvaluationDetails.<Boolean>builder()
.value(false)
.flagKey("string_key")
.reason(Reason.ERROR.name())
.errorCode(ErrorCode.TYPE_MISMATCH)
.errorMessage(
Expand Down Expand Up @@ -515,6 +519,7 @@ void should_throw_an_error_if_we_expect_a_string_and_got_another_type() {
client.getStringDetails("bool_targeting_match", "defaultValue", this.evaluationContext);
FlagEvaluationDetails<String> want = FlagEvaluationDetails.<String>builder()
.value("defaultValue")
.flagKey("bool_targeting_match")
.reason(Reason.ERROR.name())
.errorMessage(
"Flag value bool_targeting_match had unexpected type class java.lang.Boolean, expected class java.lang.String.")
Expand Down Expand Up @@ -579,6 +584,7 @@ void should_throw_an_error_if_we_expect_a_integer_and_got_another_type() {
client.getIntegerDetails("bool_targeting_match", 200, this.evaluationContext);
FlagEvaluationDetails<Integer> want = FlagEvaluationDetails.<Integer>builder()
.value(200)
.flagKey("bool_targeting_match")
.reason(Reason.ERROR.name())
.errorMessage(
"Flag value bool_targeting_match had unexpected type class java.lang.Boolean, expected class java.lang.Integer.")
Expand Down Expand Up @@ -641,6 +647,7 @@ void should_throw_an_error_if_we_expect_a_integer_and_double_type() {
FlagEvaluationDetails<Integer> got = client.getIntegerDetails("double_key", 200, this.evaluationContext);
FlagEvaluationDetails<Integer> want = FlagEvaluationDetails.<Integer>builder()
.value(200)
.flagKey("double_key")
.reason(Reason.ERROR.name())
.errorMessage(
"Flag value double_key had unexpected type class java.lang.Double, expected class java.lang.Integer.")
Expand Down Expand Up @@ -727,8 +734,10 @@ void should_resolve_a_valid_value_flag_with_TARGETING_MATCH_reason() {
.value(new Value(new MutableStructure()
.add("test", "test1")
.add("test2", false)
.add("test5", new Value())
.add("test3", 123.3)
.add("test4", 1)))
.flagKey("object_key")
.reason(Reason.TARGETING_MATCH.name())
.variant("True")
.flagMetadata(defaultMetadata)
Expand Down Expand Up @@ -772,6 +781,7 @@ void should_throw_an_error_if_no_targeting_key() {
client.getObjectDetails("string_key", new Value("CC0000"), new MutableContext());
FlagEvaluationDetails<Value> want = FlagEvaluationDetails.<Value>builder()
.value(new Value("CC0000"))
.flagKey("string_key")
.errorCode(ErrorCode.TARGETING_KEY_MISSING)
.reason(Reason.ERROR.name())
.build();
Expand Down