fix: remove redundant metadata error logs within grace period #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
aepfli,
alexandraoberaigner,
chrfwow and
guidobrei
and removed request for
Kavindu-Dodan and
thisthat
toddbaert
commented
Jun 25, 2025
...e/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java
Outdated
Show resolved
Hide resolved
…s/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java Signed-off-by: Todd Baert <[email protected]>
aepfli
approved these changes
Jun 25, 2025
beeme1mr
changed the title
beeme1mr
approved these changes
Jun 25, 2025
guidobrei
approved these changes
Jun 25, 2025
Signed-off-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now (until open-feature/flagd#1584) is done, we make the
getMetadatarequest when the stream starts. If thegetMetadatafails, we kill the stream and the normal reconnect loop executes.This just changes a redundant error log to debug, since we don't want any errors until the grace period expires.