feat: add getNumberEvaluation method delegating to getDoubleEvaluation (#501) #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-feature#501) Signed-off-by: Carla Köberl <[email protected]>
open-feature#501) Signed-off-by: Carla Köberl <[email protected]>
|
aepfli
reviewed
Jul 31, 2025
| @@ -287,9 +287,11 @@ private <T> ProviderEvaluation<?> createProviderEvaluation( | |||
| case STRING: | |||
| return provider.getStringEvaluation(key, (String) defaultValue, invocationContext); | |||
| case INTEGER: | |||
| return provider.getIntegerEvaluation(key, (Integer) defaultValue, invocationContext); | |||
| return provider.getNumberEvaluation(key, (Integer) defaultValue, invocationContext); | |||
There was a problem hiding this comment.
do we need to modify/cast here the resolved value to an Integer before returning, for backwards compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please give me some feedback. This is my second open source contribution and I'm not sure if this is the correct approach.
fixes: #501