Skip to content

fix: javadoc error on-merge action #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

fix: javadoc error on-merge action #1599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c903fd
fix: make builder visible for javadocs, move javadoc gen to codequali…
alexandraoberaigner Sep 16, 2025
cda60ed
Merge branch 'main' into fix/javadoc-issue-main
aepfli Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,29 +507,6 @@
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>deploy</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>

<plugins>
<!-- Begin publish to maven central -->
<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<version>0.8.0</version>
<extensions>true</extensions>
<configuration>
<publishingServerId>central</publishingServerId>
<autoPublish>true</autoPublish>
</configuration>
</plugin>
<!-- End publish to maven central -->

<!-- Begin source & javadocs being generated -->
Copy link
Contributor Author

@alexandraoberaigner alexandraoberaigner Sep 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[INFO] the diff looks a bit weird here. Actually this section source & javadocs being generated was moved from the deploy profile to the codequality profile

See the PR's action logs for the plugin to be run in the verify maven step:

[INFO] Building jar: /home/runner/work/java-sdk/java-sdk/target/sdk-1.17.0-javadoc.jar

<plugin>
Expand Down Expand Up @@ -565,6 +542,29 @@
</executions>
</plugin>
<!-- end source & javadoc -->
</plugins>
</build>
</profile>
<profile>
<id>deploy</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>

<plugins>
<!-- Begin publish to maven central -->
<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<version>0.8.0</version>
<extensions>true</extensions>
<configuration>
<publishingServerId>central</publishingServerId>
<autoPublish>true</autoPublish>
</configuration>
</plugin>
<!-- End publish to maven central -->

<!-- sign the jars -->
<plugin>
Expand Down
7 changes: 7 additions & 0 deletions src/main/java/dev/openfeature/sdk/HookContextWithoutData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,11 @@ static <T> HookContextWithoutData<T> from(
return new HookContextWithoutData<>(
key, type, defaultValue, ImmutableContext.EMPTY, clientMetadata, providerMetadata);
}

/**
* Make the builder visible for javadocs.
*
* @param <T> flag value type
*/
public static class HookContextWithoutDataBuilder<T> {}
}
Loading