Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@
</activation>
<build>
<plugins>
<plugin>
<!--<plugin>
<groupId>com.vmlens</groupId>
<artifactId>vmlens-maven-plugin</artifactId>
<version>1.2.14</version>
Expand All @@ -363,7 +363,7 @@
</configuration>
</execution>
</executions>
</plugin>
</plugin>-->
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.8.1</version>
Expand Down
63 changes: 32 additions & 31 deletions src/main/java/dev/openfeature/sdk/HookContext.java
Original file line number Diff line number Diff line change
@@ -1,13 +1,32 @@
package dev.openfeature.sdk;

import dev.openfeature.sdk.HookContextWithoutData.HookContextWithoutDataBuilder;
import lombok.Builder;
import lombok.NonNull;
import lombok.Value;
import lombok.With;

/**
* A interface to hold immutable context that {@link Hook} instances use.
* A data class to hold immutable context that {@link Hook} instances use.
*
* @param <T> the type for the flag being evaluated
*/
public interface HookContext<T> {
@Value
@Builder
@With
public class HookContext<T> {
@NonNull String flagKey;

@NonNull FlagValueType type;

@NonNull T defaultValue;

@NonNull EvaluationContext ctx;

ClientMetadata clientMetadata;
Metadata providerMetadata;

/**
* Builds a {@link HookContextWithoutData} instances from request data.
* Builds a {@link HookContext} instances from request data.
*
* @param key feature flag key
* @param type flag value type
Expand All @@ -17,39 +36,21 @@ public interface HookContext<T> {
* @param defaultValue Fallback value
* @param <T> type that the flag is evaluating against
* @return resulting context for hook
* @deprecated this should not be instantiated outside the SDK anymore
*/
@Deprecated
static <T> HookContext<T> from(
public static <T> HookContext<T> from(
String key,
FlagValueType type,
ClientMetadata clientMetadata,
Metadata providerMetadata,
EvaluationContext ctx,
T defaultValue) {
return new HookContextWithoutData<>(key, type, defaultValue, ctx, clientMetadata, providerMetadata);
}

/**
* Returns a builder for our default HookContext object.
*/
static <T> HookContextWithoutDataBuilder<T> builder() {
return HookContextWithoutData.<T>builder();
}

String getFlagKey();

FlagValueType getType();

T getDefaultValue();

EvaluationContext getCtx();

ClientMetadata getClientMetadata();

Metadata getProviderMetadata();

default HookData getHookData() {
return null;
return HookContext.<T>builder()
.flagKey(key)
.type(type)
.clientMetadata(clientMetadata)
.providerMetadata(providerMetadata)
.ctx(ctx)
.defaultValue(defaultValue)
.build();
}
}
50 changes: 0 additions & 50 deletions src/main/java/dev/openfeature/sdk/HookContextWithData.java

This file was deleted.

55 changes: 0 additions & 55 deletions src/main/java/dev/openfeature/sdk/HookContextWithoutData.java

This file was deleted.

81 changes: 0 additions & 81 deletions src/main/java/dev/openfeature/sdk/HookData.java

This file was deleted.

Loading
Loading