Skip to content

fix: improve vmlens handling #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

fix: improve vmlens handling #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c64c82
fix: for #1611 Only execute concurrent tests with VMLens
ThomasKrieger Sep 23, 2025
b818057
added await in ProviderSteps
ThomasKrieger Sep 24, 2025
e2b5967
Merge branch 'main' into fix/improve-vmlens-handling
chrfwow Sep 25, 2025
dfc5f9f
Merge branch 'main' into fix/improve-vmlens-handling
chrfwow Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
<dependency>
<groupId>com.vmlens</groupId>
<artifactId>api</artifactId>
<version>1.2.13</version>
<version>1.2.14</version>
<scope>test</scope>
</dependency>

Expand Down Expand Up @@ -348,7 +348,7 @@
</activation>
<build>
<plugins>
<!--<plugin>
<plugin>
<groupId>com.vmlens</groupId>
<artifactId>vmlens-maven-plugin</artifactId>
<version>1.2.14</version>
Expand All @@ -359,11 +359,14 @@
<goal>test</goal>
</goals>
<configuration>
<includes>
<include>**/*CT.java</include>
</includes>
Comment on lines +362 to +364
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for the new <includes> block seems to be inconsistent, likely due to a mix of tabs and spaces. For better readability and maintainability, it's good practice to use consistent indentation. Adopting the 4-space indentation used elsewhere in this file would improve consistency.

Suggested change
<includes>
<include>**/*CT.java</include>
</includes>
<includes>
<include>**/*CT.java</include>
</includes>

<failIfNoTests>true</failIfNoTests>
</configuration>
</execution>
</executions>
</plugin>-->
</plugin>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.8.1</version>
Expand Down
13 changes: 4 additions & 9 deletions src/test/java/dev/openfeature/sdk/e2e/steps/ProviderSteps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import io.cucumber.java.en.Given;
import io.cucumber.java.en.Then;
import java.util.Map;
import org.awaitility.Awaitility;

public class ProviderSteps {
private final State state;
Expand Down Expand Up @@ -113,19 +112,15 @@ private void setupMockProvider(ErrorCode errorCode, String errorMessage, Provide
switch (providerState) {
case FATAL:
case ERROR:
mockProvider.emitProviderReady(details);
mockProvider.emitProviderError(details);
mockProvider.emitProviderReady(details).await();
Copy link
Contributor

@chrfwow chrfwow Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

mockProvider.emitProviderError(details).await();
break;
case STALE:
mockProvider.emitProviderReady(details);
mockProvider.emitProviderStale(details);
mockProvider.emitProviderReady(details).await();
mockProvider.emitProviderStale(details).await();
break;
default:
}
Awaitility.await().until(() -> {
ProviderState providerState1 = client.getProviderState();
return providerState1 == providerState;
});
}

private void configureMockEvaluations(FeatureProvider mockProvider, ErrorCode errorCode, String errorMessage) {
Expand Down
2 changes: 1 addition & 1 deletion ...ev/openfeature/sdk/vmlens/VmLensTest.java → .../dev/openfeature/sdk/vmlens/VmLensCT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

class VmLensTest {
class VmLensCT {
final OpenFeatureAPI api = OpenFeatureAPITestUtil.createAPI();

@BeforeEach
Expand Down
Loading